You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/26 21:15:14 UTC

[GitHub] [spark] sunchao commented on pull request #32354: [SPARK-35232][SQL] Nested column pruning should retain column metadata

sunchao commented on pull request #32354:
URL: https://github.com/apache/spark/pull/32354#issuecomment-827151576


   @viirya without the change in `InMemoryTable` the test will not fail. This is because `InMemoryTable` doesn't have column pruning at the moment and it just return the table schema as the read schema in `InMemoryBatchScan`, but a more realistic data source would use the `requestedSchema` (e.g., [Iceberg](https://github.com/apache/iceberg/blob/master/spark3/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java#L132)).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org