[GitHub] [helix] desaikomal commented on a diff in pull request #2351: Add code and code translator

["desaikomal (via GitHub)" <gi...@apache.org>]

desaikomal commented on code in PR #2351:
URL: https://github.com/apache/helix/pull/2351#discussion_r1089542983


##########
meta-client/src/main/java/org/apache/helix/metaclient/exception/MetaClientException.java:
##########
@@ -35,4 +35,114 @@ public MetaClientException(String message) {
   public MetaClientException(Throwable cause) {
     super(cause);
   }
+
+  public enum Code {

Review Comment:
   Should we call ReturnCode ?? Code name sounds a bit confusing



##########
meta-client/src/main/java/org/apache/helix/metaclient/exception/MetaClientException.java:
##########
@@ -35,4 +35,114 @@ public MetaClientException(String message) {
   public MetaClientException(Throwable cause) {
     super(cause);
   }
+
+  public enum Code {
+    /** Everything is OK. */
+    OK,
+
+    /** Indicates a system and server-side errors not defined by following codes.
+     * It also indicate a range. Any value larger than this and less than DBUSERERROR
+     * indicating error from server side.*/
+    DBSYSTEMERROR,
+
+    /** Connection to the server has been lost. */
+    CONNECTIONLOSS,
+
+    /** Operation is unimplemented. */
+    UNIMPLEMENTED,
+
+    /** Operation timeout. */
+    OPERATIONTIMEOUT,

Review Comment:
   OPERATION_TIMEOUT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org