You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Michiel Eghuizen (JIRA)" <ji...@apache.org> on 2010/02/26 15:33:27 UTC

[jira] Commented: (SHINDIG-1175) Conflicting OAuth.php imports - src/social/oauth/OAuth.php and src/gadgets/oauth/OAuth.php

    [ https://issues.apache.org/jira/browse/SHINDIG-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838883#action_12838883 ] 

Michiel Eghuizen commented on SHINDIG-1175:
-------------------------------------------

I've patched this issue in my installation of Shindig. Because I intergrate this project into KohanaPHP, which is a PHP framework. I got some conflicts with class declaration. And those 2 OAuth classes where most of the parts the same. They also had a few bugs, So for me I've patched it and it is working. I will also attach a patch of it, but I first need to squash 2 more bugs.

What I've done is the following:
* I merged the 2 OAuth.php files by hand.
* Bugs I located in OAuth.php I immediatly fixed
* I've added social/oauth to gadgets/oauth and removed the folder social/oauth, so the OAuth lib is only on 1 place instead of 2
* I've changed the requires/includes so they reference to the social/oauth folder

Now I'm going to test it, squash some bugs as well and post the changes.

> Conflicting OAuth.php imports - src/social/oauth/OAuth.php and src/gadgets/oauth/OAuth.php
> ------------------------------------------------------------------------------------------
>
>                 Key: SHINDIG-1175
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1175
>             Project: Shindig
>          Issue Type: Bug
>          Components: PHP
>            Reporter: Arne Roomann-Kurrik
>
> Looks like two different versions of the OAuth.php library were pulled into /src/social and /src/gadgets.  
> A single copy of the OAuth library probably belongs in /external
> In certain cases, each file defining OAuthException throws an error when the autoloader discovers both OAuth.php files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.