[GitHub] [superset] lilykuang commented on a diff in pull request #22596: chore: upgrade react-redux

[GitBox <gi...@apache.org>]

lilykuang commented on code in PR #22596:
URL: https://github.com/apache/superset/pull/22596#discussion_r1062992012


##########
superset-frontend/package.json:
##########
@@ -178,7 +178,7 @@
     "react-lines-ellipsis": "^0.15.0",
     "react-loadable": "^5.5.0",
     "react-query": "^3.39.2",
-    "react-redux": "^7.2.0",

Review Comment:
   I tried updating to react-redux to 8.0.5 but there is a type issue with action returned from `useDispatch()`. 
   I also tried the recommended solution from https://redux.js.org/usage/usage-with-typescript#define-typed-hooks still  didn't resolve the type issue.  `dispatch<any>()` work but it only silent the error. We can hold off the update until we figure how  to resolve this type issue



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org