You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by David Glasser <gl...@mit.edu> on 2006/12/13 01:40:47 UTC
Re: svn commit: r22678 - trunk/subversion/libsvn_client
On 12/12/06, dlr@tigris.org <dl...@tigris.org> wrote:
>
> +/* CTX is of type "svn_client_ctx_t *". */
> +#define SVN_CLIENT__HAS_LOG_MSG_FUNC(ctx) \
> + (ctx->log_msg_func3 || ctx->log_msg_func2 || ctx->log_msg_func)
> +
Shouldn't the ctx's in the expansion be parenthesized to avoid
precedence mixups if the argument is weird?
--dave
--
David Glasser | glasser@mit.edu | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r22678 - trunk/subversion/libsvn_client
Posted by Daniel Rall <dl...@collab.net>.
On Tue, 12 Dec 2006, David Glasser wrote:
> On 12/12/06, dlr@tigris.org <dl...@tigris.org> wrote:
>
> >
> >+/* CTX is of type "svn_client_ctx_t *". */
> >+#define SVN_CLIENT__HAS_LOG_MSG_FUNC(ctx) \
> >+ (ctx->log_msg_func3 || ctx->log_msg_func2 || ctx->log_msg_func)
> >+
>
> Shouldn't the ctx's in the expansion be parenthesized to avoid
> precedence mixups if the argument is weird?
I'll buy that for a dollar! r22680, thanks Dave.
- Dan