[GitHub] [spark] zhenlineo commented on a diff in pull request #40075: [WIP] [CONNECT] Scala Client DataFrameWriterV2

["zhenlineo (via GitHub)" <gi...@apache.org>]

zhenlineo commented on code in PR #40075:
URL: https://github.com/apache/spark/pull/40075#discussion_r1110468795


##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/ClientE2ETestSuite.scala:
##########
@@ -156,6 +156,19 @@ class ClientE2ETestSuite extends RemoteSparkSession {
     }
   }
 
+  test("write v2") {
+    try {
+      spark.range(3).writeTo("myTableV2").using("parquet").create()

Review Comment:
   This API feels wrong, a few errors I get with this API:
   ```
   spark.range(3).writeTo("myTableV2").create() -> Error: should specify source
   ```
   
   ```
   spark.range(3).writeTo("myTableV2").using("parquet").createOrReplace() -> Error: dose not support create or select.
   ```
   
   ```
   spark.range(3).writeTo("myTableV2").using("parquet").create()
   spark.range(3).writeTo("myTableV2").append() -> Error: Cannot write into v1 table
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org