You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "kidylee (via GitHub)" <gi...@apache.org> on 2023/03/23 11:43:43 UTC
[GitHub] [incubator-opendal] kidylee opened a new pull request, #1736: feat(bindings/java): add java binding
kidylee opened a new pull request, #1736:
URL: https://github.com/apache/incubator-opendal/pull/1736
- [ ] Exceptions need polish to conform Java files related interface.
- [ ] Cucumber test cases
- [ ] Experiment: Java doesn't support async/await hence using Kotlin to implement async related API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] suyanhanx commented on pull request #1736: feat(bindings/java): add java binding
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on PR #1736:
URL: https://github.com/apache/incubator-opendal/pull/1736#issuecomment-1481079630
You may track them in #1572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] suyanhanx commented on pull request #1736: feat(bindings/java): add java binding
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on PR #1736:
URL: https://github.com/apache/incubator-opendal/pull/1736#issuecomment-1481082168
> * Java doesn't native support async/await, maybe we can try Kotlin.
Sounds good. Can it be integrated? Or is it possible to directly implement Java binding using Kotlin?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on pull request #1736: feat(bindings/java): add java binding
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #1736:
URL: https://github.com/apache/incubator-opendal/pull/1736#issuecomment-1481107005
> A open question is how do we handling running model for Executor and Waker
We can consider implementing them in the future, but for now let's prioritize blocking support. I believe it's best to address one problem at a time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] kidylee commented on pull request #1736: feat(bindings/java): add java binding
Posted by "kidylee (via GitHub)" <gi...@apache.org>.
kidylee commented on PR #1736:
URL: https://github.com/apache/incubator-opendal/pull/1736#issuecomment-1481065974
> > * Readme for usage
> > * [ ] Development/Contribution guide.
> > * [ ] Exceptions need polish to conform Java files related interface.
> > * [ ] Cucumber test cases
> > * [ ] Experiment: Java doesn't support async/await hence using Kotlin to implement async related API.
>
> Thank you for the pull request! At OpenDAL, we prefer to split pull requests into smaller chunks for faster review and merging. It would be better if we create a tracking issue instead.
>
> In this PR, I expect to the basic setup, and future impove can be done later.
Sure, I will put them in readme for memo and will add issues after this pr get merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo merged pull request #1736: feat(bindings/java): add java binding
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #1736:
URL: https://github.com/apache/incubator-opendal/pull/1736
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] kidylee commented on a diff in pull request #1736: feat(bindings/java): add java binding
Posted by "kidylee (via GitHub)" <gi...@apache.org>.
kidylee commented on code in PR #1736:
URL: https://github.com/apache/incubator-opendal/pull/1736#discussion_r1147500572
##########
bindings/java/src/main/rust/opendal-java/src/lib.rs:
##########
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #1736: feat(bindings/java): add java binding
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #1736:
URL: https://github.com/apache/incubator-opendal/pull/1736#discussion_r1146424159
##########
bindings/java/src/main/rust/opendal-java/src/lib.rs:
##########
Review Comment:
Can we put this file in `bindings/java/src`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on pull request #1736: feat(bindings/java): add java binding
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #1736:
URL: https://github.com/apache/incubator-opendal/pull/1736#issuecomment-1481059342
> * Readme for usage
> * [ ] Development/Contribution guide.
> * [ ] Exceptions need polish to conform Java files related interface.
> * [ ] Cucumber test cases
> * [ ] Experiment: Java doesn't support async/await hence using Kotlin to implement async related API.
Thank you for the pull request! At OpenDAL, we prefer to split pull requests into smaller chunks for faster review and merging. It would be better if we create a tracking issue instead.
In this PR, I expect to the basic setup, and future impove can be done later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on pull request #1736: feat(bindings/java): add java binding
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #1736:
URL: https://github.com/apache/incubator-opendal/pull/1736#issuecomment-1481071758
You can use the following command to format license:
```shell
docker run -it --rm -v $(pwd):/github/workspace -u $(id -u):$(id -g) ghcr.io/korandoru/hawkeye-native format
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] kidylee commented on pull request #1736: feat(bindings/java): add java binding
Posted by "kidylee (via GitHub)" <gi...@apache.org>.
kidylee commented on PR #1736:
URL: https://github.com/apache/incubator-opendal/pull/1736#issuecomment-1481101797
> You may track them in #1572
Thanks.
> > * Java doesn't native support async/await, maybe we can try Kotlin.
>
> Sounds good. Can it be integrated? Or is it possible to directly implement Java binding using Kotlin?
Yes, both integration or writing in Kotlin entirely work for Java and Kotlin. A open question is how do we handling running model for Executor and Waker:
* Keep them in Kotlin
* Keep them in Rust
* Both language has them separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org