You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "dpgaspar (via GitHub)" <gi...@apache.org> on 2023/06/30 10:02:33 UTC
[GitHub] [superset] dpgaspar opened a new pull request, #24565: fix: docker compose refusing to start
dpgaspar opened a new pull request, #24565:
URL: https://github.com/apache/superset/pull/24565
### SUMMARY
Currently `docker-compose up` is refusing to start since debug is not enabled anymore.
We now use `FLASK_DEBUG=true` since `FLASK_ENV` is deprecated
This is a small fix for it
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a diff in pull request #24565: fix: docker compose refusing to start
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on code in PR #24565:
URL: https://github.com/apache/superset/pull/24565#discussion_r1247699527
##########
docker/docker-bootstrap.sh:
##########
@@ -46,7 +46,7 @@ case "${1}" in
celery --app=superset.tasks.celery_app:app beat --pidfile /tmp/celerybeat.pid -l INFO -s "${SUPERSET_HOME}"/celerybeat-schedule
;;
app)
- echo "Starting web app..."
+ echo "Starting web app on debug..."
Review Comment:
I'm probably missing something, but isn't this conditional on `FLASK_DEBUG` being set to true?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on a diff in pull request #24565: fix: docker compose refusing to start
Posted by "dpgaspar (via GitHub)" <gi...@apache.org>.
dpgaspar commented on code in PR #24565:
URL: https://github.com/apache/superset/pull/24565#discussion_r1247709552
##########
docker/docker-bootstrap.sh:
##########
@@ -46,7 +46,7 @@ case "${1}" in
celery --app=superset.tasks.celery_app:app beat --pidfile /tmp/celerybeat.pid -l INFO -s "${SUPERSET_HOME}"/celerybeat-schedule
;;
app)
- echo "Starting web app..."
+ echo "Starting web app on debug..."
Review Comment:
You're right, but there's the debugger and the debug on flask
"The debugger is enabled by default when the development server is run in debug mode."
adding "debug" here is not correct, I want to differentiate between starting with Flask or gunicorn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar merged pull request #24565: fix: docker compose refusing to start
Posted by "dpgaspar (via GitHub)" <gi...@apache.org>.
dpgaspar merged PR #24565:
URL: https://github.com/apache/superset/pull/24565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] prakhyatc commented on pull request #24565: fix: docker compose refusing to start
Posted by "prakhyatc (via GitHub)" <gi...@apache.org>.
prakhyatc commented on PR #24565:
URL: https://github.com/apache/superset/pull/24565#issuecomment-1641070856
Insightful
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org