You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/09/03 02:24:44 UTC

[GitHub] [incubator-echarts] quillblue opened a new pull request #13225: Fix #13195 - Update way of parsing string to date

quillblue opened a new pull request #13225:
URL: https://github.com/apache/incubator-echarts/pull/13225


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [X] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   The PR updated way of parsing 7th part of date string from simply treat it as milliseconds to pick first 3 digits as milliseconds to avoid unexpected result when backend API return date string with precision of microseconds.
   
   ### Fixed issues
   
   #13195 
   
   
   ## Details
   
   ### Before: What was the problem?
   
   Though 3 digits milliseconds is widely used in most situations, some date formatter will return date string 6 digit microseconds (`yyyy-MM-ddTHH:mm:ss.micros`) . ECharts will treat micro seconds as milliseconds when parsing DateTime string and cause unexpected result.
   
   ### After: How is it fixed in this PR?
   
   Keep conistent with default constructor of JavaScript Date - only pick first 3 digits when the length of input part between dot and zulu time marker is longer than 3 digits.
   
   ## Usage
   
   ### Are there any API changes?
   
   - [ ] The API has been changed.
   
   <!-- LIST THE API CHANGES HERE -->
   
   
   
   ### Related test cases or examples to use the new APIs
   
   NA.
   
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merge.
   
   ### Other information
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] quillblue closed pull request #13225: Fix #13195 - Update way of parsing string to date

Posted by GitBox <gi...@apache.org>.
quillblue closed pull request #13225:
URL: https://github.com/apache/incubator-echarts/pull/13225


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] quillblue commented on pull request #13225: Fix #13195 - Update way of parsing string to date

Posted by GitBox <gi...@apache.org>.
quillblue commented on pull request #13225:
URL: https://github.com/apache/incubator-echarts/pull/13225#issuecomment-686285789


   Close this as will submit another PR to `next` branch per suggestion from community


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13225: Fix #13195 - Update way of parsing string to date

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13225:
URL: https://github.com/apache/incubator-echarts/pull/13225#issuecomment-686193806


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org