[GitHub] [hive] atsaonerk commented on pull request #3444: AS[]: Dump Tables in parallel

[GitBox <gi...@apache.org>]

atsaonerk commented on PR #3444:
URL: https://github.com/apache/hive/pull/3444#issuecomment-1196385694

   > Need to test the test too.
   > 
   > Add a test like this:
   > 
   > public void testDumpExporterWithParallelismFail() throws Exception { when(conf.getIntVar(HiveConf.ConfVars.REPL_EXPORT_DUMP_PARALLELISM)).thenReturn(10); sem = new Semaphore(totalTask-1);
   > 
   > This test should fail intentionally. So you will need to catch the exception and PASS if it fails. I think there is an annotation for that like
   > 
   > @test(expected=NullPointerException.class)
   > 
   > replace with your exception
   
   What is the failure expected?
   We have for e.g 7 semaphore limits and executing 8 runnable task.
   The 8th one wont get semaphore and return without incrementing task number.
   The ASSURE_TRUE(7,8) will fail. Is this the one you are saying?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org