You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/01/05 01:43:34 UTC
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #13590: Support IP as advertisedAddress if not set
Anonymitaet commented on a change in pull request #13590:
URL: https://github.com/apache/pulsar/pull/13590#discussion_r778494868
##########
File path: site2/docs/reference-configuration.md
##########
@@ -162,7 +162,8 @@ Pulsar brokers are responsible for handling incoming messages from producers, di
|jvmGCMetricsLoggerClassName|Classname of Pluggable JVM GC metrics logger that can log GC specific metrics.|N/A|
|bindAddress| Hostname or IP address the service binds on, default is 0.0.0.0. |0.0.0.0|
|bindAddresses| Additional Hostname or IP addresses the service binds on: `listener_name:scheme://host:port,...`. ||
-|advertisedAddress| Hostname or IP address the service advertises to the outside world. If not set, the value of `InetAddress.getLocalHost().getHostName()` is used. ||
+|advertisedAddress| Hostname or IP address the service advertises to the outside world. If not set, the value of `InetAddress.getLocalHost().getHostName()` is used by default, or `InetAddress.getLocalHost().getHostAddress()` if `ipAsAdvertisedAddress` is true ||
Review comment:
```suggestion
|advertisedAddress| Hostname or IP address the service advertises to the outside world. If `advertisedAddress` is not set, the value of `InetAddress.getLocalHost().getHostName()` is used by default. If `advertisedAddress` is not set and `ipAsAdvertisedAddress` is set to true, the value of `InetAddress.getLocalHost().getHostAddress()` is used. ||
```
do you mean this?
##########
File path: site2/docs/reference-configuration.md
##########
@@ -162,7 +162,8 @@ Pulsar brokers are responsible for handling incoming messages from producers, di
|jvmGCMetricsLoggerClassName|Classname of Pluggable JVM GC metrics logger that can log GC specific metrics.|N/A|
|bindAddress| Hostname or IP address the service binds on, default is 0.0.0.0. |0.0.0.0|
|bindAddresses| Additional Hostname or IP addresses the service binds on: `listener_name:scheme://host:port,...`. ||
-|advertisedAddress| Hostname or IP address the service advertises to the outside world. If not set, the value of `InetAddress.getLocalHost().getHostName()` is used. ||
+|advertisedAddress| Hostname or IP address the service advertises to the outside world. If not set, the value of `InetAddress.getLocalHost().getHostName()` is used by default, or `InetAddress.getLocalHost().getHostAddress()` if `ipAsAdvertisedAddress` is true ||
+|ipAsAdvertisedAddress| If set true and `advertisedAddress` not set, the value of `InetAddress.getLocalHost().getHostAddress()` is used to set to advertisedAddress|false|
Review comment:
```suggestion
|ipAsAdvertisedAddress| If `ipAsAdvertisedAddress` is set to true and `advertisedAddress` is not set, the value of `InetAddress.getLocalHost().getHostAddress()` is used to set tthe advertised address. |false|
```
do you mean this?
##########
File path: site2/docs/reference-configuration.md
##########
@@ -437,7 +438,8 @@ You can set the log level and configuration in the [log4j2.yaml](https://github
|webServicePort| The port used by the standalone broker for HTTP requests |8080|
|bindAddress| The hostname or IP address on which the standalone service binds |0.0.0.0|
|bindAddresses| Additional Hostname or IP addresses the service binds on: `listener_name:scheme://host:port,...`. ||
-|advertisedAddress| The hostname or IP address that the standalone service advertises to the outside world. If not set, the value of `InetAddress.getLocalHost().getHostName()` is used. ||
+|advertisedAddress| Hostname or IP address the service advertises to the outside world. If not set, the value of `InetAddress.getLocalHost().getHostName()` is used by default, or `InetAddress.getLocalHost().getHostAddress()` if `ipAsAdvertisedAddress` is true ||
+|ipAsAdvertisedAddress| If set true and `advertisedAddress` not set, the value of `InetAddress.getLocalHost().getHostAddress()` is used to set to advertisedAddress|false|
Review comment:
same comment
##########
File path: site2/docs/reference-configuration.md
##########
@@ -705,7 +707,8 @@ The [Pulsar proxy](concepts-architecture-overview.md#pulsar-proxy) can be config
| functionWorkerWebServiceURLTLS | The TLS Web service URL pointing to the function worker cluster. It is only configured when you setup function workers in a separate cluster. | |
|zookeeperSessionTimeoutMs| ZooKeeper session timeout (in milliseconds) |30000|
|zooKeeperCacheExpirySeconds|ZooKeeper cache expiry time in seconds|300|
-|advertisedAddress|Hostname or IP address the service advertises to the outside world. If not set, the value of `InetAddress.getLocalHost().getHostname()` is used.|N/A|
+|advertisedAddress| Hostname or IP address the service advertises to the outside world. If not set, the value of `InetAddress.getLocalHost().getHostName()` is used by default, or `InetAddress.getLocalHost().getHostAddress()` if `ipAsAdvertisedAddress` is true ||
+|ipAsAdvertisedAddress| If set true and `advertisedAddress` not set, the value of `InetAddress.getLocalHost().getHostAddress()` is used to set to advertisedAddress|false|
Review comment:
same comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org