You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/03/22 05:15:08 UTC
Review Request: Fixed libprocess http::get to close the socket.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10073/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
Libprocess-only change.
This was discovered via: MESOS-404.
This addresses bug MESOS-404.
https://issues.apache.org/jira/browse/MESOS-404
Diffs
-----
third_party/libprocess/src/process.cpp d5d94f433e24806690b575f7c4f6fafcf84c4ab3
Diff: https://reviews.apache.org/r/10073/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request: Fixed libprocess http::get to close the socket.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10073/#review18289
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On March 22, 2013, 7:11 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10073/
> -----------------------------------------------------------
>
> (Updated March 22, 2013, 7:11 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> Libprocess-only change.
> This was discovered via: MESOS-404.
>
>
> This addresses bug MESOS-404.
> https://issues.apache.org/jira/browse/MESOS-404
>
>
> Diffs
> -----
>
> third_party/libprocess/src/process.cpp d5d94f433e24806690b575f7c4f6fafcf84c4ab3
>
> Diff: https://reviews.apache.org/r/10073/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Fixed libprocess http::get to close the socket.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10073/#review18285
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 22, 2013, 7:11 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10073/
> -----------------------------------------------------------
>
> (Updated March 22, 2013, 7:11 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> Libprocess-only change.
> This was discovered via: MESOS-404.
>
>
> This addresses bug MESOS-404.
> https://issues.apache.org/jira/browse/MESOS-404
>
>
> Diffs
> -----
>
> third_party/libprocess/src/process.cpp d5d94f433e24806690b575f7c4f6fafcf84c4ab3
>
> Diff: https://reviews.apache.org/r/10073/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Fixed libprocess http::get to close the socket.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10073/
-----------------------------------------------------------
(Updated March 22, 2013, 7:11 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Vinod's review.
Description
-------
Libprocess-only change.
This was discovered via: MESOS-404.
This addresses bug MESOS-404.
https://issues.apache.org/jira/browse/MESOS-404
Diffs (updated)
-----
third_party/libprocess/src/process.cpp d5d94f433e24806690b575f7c4f6fafcf84c4ab3
Diff: https://reviews.apache.org/r/10073/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request: Fixed libprocess http::get to close the socket.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10073/#review18241
-----------------------------------------------------------
third_party/libprocess/src/process.cpp
<https://reviews.apache.org/r/10073/#comment38453>
Can you stick this up the above statement?
Future<Response> response = io::read()
.then()
.any()
this makes it more clear imo.
- Vinod Kone
On March 22, 2013, 4:15 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10073/
> -----------------------------------------------------------
>
> (Updated March 22, 2013, 4:15 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> Libprocess-only change.
> This was discovered via: MESOS-404.
>
>
> This addresses bug MESOS-404.
> https://issues.apache.org/jira/browse/MESOS-404
>
>
> Diffs
> -----
>
> third_party/libprocess/src/process.cpp d5d94f433e24806690b575f7c4f6fafcf84c4ab3
>
> Diff: https://reviews.apache.org/r/10073/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>