You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/04 01:46:38 UTC

[GitHub] [incubator-doris] caiconghui commented on a diff in pull request #8838: [fix](ut) fix fe run CreateTableAsSelectStmtTest ,UserPropertyTest, ProjectPlannerFunctionTest and AggregateTest failed

caiconghui commented on code in PR #8838:
URL: https://github.com/apache/incubator-doris/pull/8838#discussion_r841316788


##########
fe/fe-core/src/main/java/org/apache/doris/analysis/SlotRef.java:
##########
@@ -74,9 +74,6 @@ public SlotRef(SlotDescriptor desc) {
         this.type = desc.getType();
         // TODO(zc): label is meaningful
         this.label = null;
-        if (this.type.equals(Type.CHAR)) {

Review Comment:
   already do some test, but I am not sure for all case, because the motivation to transfer char to varchar in unknown for me



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org