You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by vi...@apache.org on 2021/08/09 20:54:57 UTC

[superset] 10/11: fix: move watermark to about section (#16097)

This is an automated email from the ASF dual-hosted git repository.

villebro pushed a commit to branch 1.3
in repository https://gitbox.apache.org/repos/asf/superset.git

commit ce48f54a0154376a2d56126f4c1efb1865afd0b1
Author: ʈᵃᵢ <td...@gmail.com>
AuthorDate: Fri Aug 6 05:48:22 2021 -0700

    fix: move watermark to about section (#16097)
    
    (cherry picked from commit b80f0186915b91df03f5ee5c15eba4b176596a96)
---
 superset-frontend/src/components/Menu/MenuRight.tsx | 17 +++++------------
 1 file changed, 5 insertions(+), 12 deletions(-)

diff --git a/superset-frontend/src/components/Menu/MenuRight.tsx b/superset-frontend/src/components/Menu/MenuRight.tsx
index 6a50a94..86a4784 100644
--- a/superset-frontend/src/components/Menu/MenuRight.tsx
+++ b/superset-frontend/src/components/Menu/MenuRight.tsx
@@ -69,15 +69,6 @@ const StyledAnchor = styled.a`
   padding-left: ${({ theme }) => theme.gridUnit}px;
 `;
 
-const WaterMark = styled.span`
-  font-size: 13px;
-  color: #b0b4c3;
-  margin: 0 ${({ theme }) => theme.gridUnit * 4}px;
-  @media (max-width: 1070px) {
-    display: none;
-  }
-`;
-
 const { SubMenu } = Menu;
 
 interface RightMenuProps {
@@ -95,9 +86,6 @@ const RightMenu = ({
 }: RightMenuProps) => (
   <StyledDiv align={align}>
     <Menu mode="horizontal">
-      {navbarRight.show_watermark && (
-        <WaterMark>{t('Powered by Apache Superset')}</WaterMark>
-      )}
       {!navbarRight.user_is_anonymous && (
         <SubMenu
           data-test="new-dropdown"
@@ -160,6 +148,11 @@ const RightMenu = ({
           <Menu.Divider key="version-info-divider" />,
           <Menu.ItemGroup key="about-section" title={t('About')}>
             <div className="about-section">
+              {navbarRight.show_watermark && (
+                <div css={versionInfoStyles}>
+                  {t('Powered by Apache Superset')}
+                </div>
+              )}
               {navbarRight.version_string && (
                 <div css={versionInfoStyles}>
                   Version: {navbarRight.version_string}