[GitHub] brodybits opened a new pull request #633: [WIP] Quick fix for inconsistent SDK versions - WIP with TEST TODO

[GitBox <gi...@apache.org>]

brodybits opened a new pull request #633: [WIP] Quick fix for inconsistent SDK versions - WIP with TEST TODO
URL: https://github.com/apache/cordova-android/pull/633
 
 
   Resolves #508 - Inconsistent handling of min/target SDK values
   
   This is a quick fix to use the minimum & target SDK version values from AndroidManifest.xml.
   
   I have tested it in a newly generated Cordova project from the command line.
   
   This proposal also resolves #631 - Target SDK version not consistent with defaults in root build.gradle bug
   
   TODO item:
   
   - [ ] update unit tests to succeed with the new code change
   - [ ] update unit tests to cover extracting minimum & target SDK version values from AndroidManifest.xml
   
   Unfortunately this does NOT resolve #629 (errors encountered on Android Studio 3.2 & 3.3).
   
   I really hope this kind of a solution will be part of the upcoming major release for Cordova 9 (apache/cordova#10).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org