You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/05 14:17:12 UTC

[GitHub] [airflow] joppevos opened a new pull request, #22753: migrate system test gcs_to_bigquery into new design

joppevos opened a new pull request, #22753:
URL: https://github.com/apache/airflow/pull/22753

   Migration of a google system tests to the new design, following document [AIP-47](https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-47+New+design+of+Airflow+System+Tests).
   
   issue: https://github.com/apache/airflow/issues/22447


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #22753: migrate system test gcs_to_bigquery into new design

Posted by GitBox <gi...@apache.org>.
potiuk merged PR #22753:
URL: https://github.com/apache/airflow/pull/22753


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] Bowrna commented on pull request #22753: migrate system test gcs_to_bigquery into new design

Posted by GitBox <gi...@apache.org>.
Bowrna commented on PR #22753:
URL: https://github.com/apache/airflow/pull/22753#issuecomment-1094296141

   @joppevos 
   I tried to write a similar system tests design for Elasticsearch and I was running into issues. (https://github.com/apache/airflow/pull/22811)
   Can you help me by telling me if you faced similar issues like the one in the comments in https://github.com/apache/airflow/pull/22811#issuecomment-1092007009 PR?
   It would be helpful if you could check this PR and point out mistakes if there is any in it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] joppevos commented on pull request #22753: migrate system test gcs_to_bigquery into new design

Posted by GitBox <gi...@apache.org>.
joppevos commented on PR #22753:
URL: https://github.com/apache/airflow/pull/22753#issuecomment-1090183791

   > Looks good! You can also remove the `test_gcs_to_bigquery_system.py` (not needed anymore with new design).
   
   Good catch! Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] bhirsz commented on pull request #22753: migrate system test gcs_to_bigquery into new design

Posted by GitBox <gi...@apache.org>.
bhirsz commented on PR #22753:
URL: https://github.com/apache/airflow/pull/22753#issuecomment-1090115864

   Looks good! You can also remove the ``test_gcs_to_bigquery_system.py`` (not needed anymore with new design). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] joppevos commented on pull request #22753: migrate system test gcs_to_bigquery into new design

Posted by GitBox <gi...@apache.org>.
joppevos commented on PR #22753:
URL: https://github.com/apache/airflow/pull/22753#issuecomment-1094328229

   > @joppevos I tried to write a similar system tests design for Elasticsearch and I was running into issues. (#22811) Can you help me by telling me if you faced similar issues like the one in the comments in [#22811 (comment)](https://github.com/apache/airflow/pull/22811#issuecomment-1092007009) PR? It would be helpful if you could check this PR and point out mistakes if there is any in it.
   
   Hey I actually did! I will comment in your PR 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org