[GitHub] [spark] JkSelf commented on issue #21899: [SPARK-24912][SQL] Don't obscure source of OOM during broadcast join

[GitBox <gi...@apache.org>]

JkSelf commented on issue #21899: [SPARK-24912][SQL] Don't obscure source of OOM during broadcast join
URL: https://github.com/apache/spark/pull/21899#issuecomment-495055518
 
 
   @beliefer Thanks for your working.  Here before we new the newPage in `val newPage = new Array[Long](newNumWords.toInt)`, we already check the available memory by `ensureAcquireMemory(newNumWords * 8L)`  and if enough memory, we will do the creation operation of `newPage`. And if the memory is enough, why throw the oom exception in `val newPage = new Array[Long](newNumWords.toInt)`? Thanks for your help.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org