svn commit: r657354 - in /httpd/httpd/trunk: CHANGES configure.in

[ni...@apache.org]

Author: niq
Date: Sat May 17 06:34:58 2008
New Revision: 657354

URL: http://svn.apache.org/viewvc?rev=657354&view=rev
Log:
configure: Don't reject libtool 2.x
PR 44817

Modified:
    httpd/httpd/trunk/CHANGES
    httpd/httpd/trunk/configure.in

Modified: httpd/httpd/trunk/CHANGES
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/CHANGES?rev=657354&r1=657353&r2=657354&view=diff
==============================================================================
--- httpd/httpd/trunk/CHANGES [utf-8] (original)
+++ httpd/httpd/trunk/CHANGES [utf-8] Sat May 17 06:34:58 2008
@@ -2,6 +2,9 @@
 Changes with Apache 2.3.0
 [ When backported to 2.2.x, remove entry from this file ]
 
+  *) configure: Don't reject libtool 2.x
+     PR 44817 [Arfrever Frehtes Taifersar Arahesis <Arfrever.FTA gmail.com>]
+
   *) suexec: When group is given as a numeric gid, validate it by looking up
      the actual group name such that the name can be used in log entries.
      PR 7862 [<y-koga apache.or.jp>, Leif W <warp-9.9 usa.net>]

Modified: httpd/httpd/trunk/configure.in
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/configure.in?rev=657354&r1=657353&r2=657354&view=diff
==============================================================================
--- httpd/httpd/trunk/configure.in (original)
+++ httpd/httpd/trunk/configure.in Sat May 17 06:34:58 2008
@@ -69,7 +69,7 @@
 
 if test "x$with_included_apr" = "xyes"; then
    apr_found=reconfig
-   apr_config="$srcdir/srclib/apr/apr-${apr_version}-config"
+   apr_config="./srclib/apr/apr-${apr_version}-config"
 else 
    APR_FIND_APR("$srcdir/srclib/apr", "./srclib/apr", 1, ${apr_version})
 fi
@@ -106,7 +106,7 @@
 
 if test "x$with_included_apr" = "xyes"; then
    apu_found=reconfig
-   apu_config="${srcdir}/srclib/apr-util/apu-${apu_version}-config"
+   apu_config="./srclib/apr-util/apu-${apu_version}-config"
 else 
    APR_FIND_APU("$srcdir/srclib/apr-util", "./srclib/apr-util", 1, ${apu_version})
 fi
@@ -237,7 +237,7 @@
       LIBTOOL="$my_libtool \$(LTFLAGS)"
       libtoolversion=`$my_libtool --version`
       case $libtoolversion in
-          *1.[[45]]*)
+          *1.[[45]]* | *[[2-9]].[[0-9]]*)
               SH_LIBTOOL='$(LIBTOOL)'
               SHLTCFLAGS="-prefer-pic"
               LTCFLAGS="-prefer-non-pic -static"

Re: svn commit: r657354 - in /httpd/httpd/trunk: CHANGES configure.in

[Nick Kew <ni...@webthing.com>]

On Sun, 18 May 2008 11:16:29 +0900
Takashi Sato <ta...@lans-tv.com> wrote:

> PR44631 "with-included-apr fails to work when using a separate
> buildroot" https://issues.apache.org/bugzilla/show_bug.cgi?id=44631
> 
> Isn't it?

Yep.  Thanks for the reminder.

Now I remember: I'd test-driven the patch, and tried to ping the
original reporter (who is a regular on IRC) to clarify things
before committing.  But pinging him failed, and I forgot about it.

-- 
Nick Kew

Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/

Re: svn commit: r657354 - in /httpd/httpd/trunk: CHANGES configure.in

[Takashi Sato <ta...@lans-tv.com>]

PR44631 "with-included-apr fails to work when using a separate buildroot"
https://issues.apache.org/bugzilla/show_bug.cgi?id=44631

Isn't it?

Re: svn commit: r657354 - in /httpd/httpd/trunk: CHANGES configure.in

[Nick Kew <ni...@webthing.com>]

On Sat, 17 May 2008 11:21:25 -0400
"Eric Covener" <co...@gmail.com> wrote:

> On Sat, May 17, 2008 at 9:34 AM,  <ni...@apache.org> wrote:
> 
> > -   apu_config="${srcdir}/srclib/apr-util/apu-${apu_version}-config"
> > +   apu_config="./srclib/apr-util/apu-${apu_version}-config"
> 
> Intentional?
> 

Nope, must've been in my local version without knowing it.  Bah.

Seeing that reminds me there was some bug with srcdir/srclib.
The above was either an uncommitted fix or an experiment that
should've been reverted.  I'll see if I can find the report
in question.

-- 
Nick Kew

Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/

Re: svn commit: r657354 - in /httpd/httpd/trunk: CHANGES configure.in

[Ruediger Pluem <rp...@apache.org>]

On 05/17/2008 05:21 PM, Eric Covener wrote:
> On Sat, May 17, 2008 at 9:34 AM,  <ni...@apache.org> wrote:
> 
>> -   apu_config="${srcdir}/srclib/apr-util/apu-${apu_version}-config"
>> +   apu_config="./srclib/apr-util/apu-${apu_version}-config"
> 
> Intentional?

That was also my question. What has this to do with the libtool version?

Regards

Rüdiger

Re: svn commit: r657354 - in /httpd/httpd/trunk: CHANGES configure.in

[Eric Covener <co...@gmail.com>]

On Sat, May 17, 2008 at 9:34 AM,  <ni...@apache.org> wrote:

> -   apu_config="${srcdir}/srclib/apr-util/apu-${apu_version}-config"
> +   apu_config="./srclib/apr-util/apu-${apu_version}-config"

Intentional?

-- 
Eric Covener
covener@gmail.com