You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/05/06 09:37:38 UTC

[GitHub] [ozone] rakeshadr opened a new pull request, #3386: HDDS-6708. [FSO] Make normalize keyPath on key rename request

rakeshadr opened a new pull request, #3386:
URL: https://github.com/apache/ozone/pull/3386

   ## What changes were proposed in this pull request?
   
   Path normalization missed in o3fs#renameKeyWithFSO, which will result in extra "/" in OM operations especially checkACLs logic.
   
   Fix: Convert #pathToKey() on ozone client and perform #validateAndNormalizeKey() at OM RenameRequest.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-6708
   
   ## How was this patch tested?
   
   Added UT.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] rakeshadr commented on pull request #3386: HDDS-6708. [FSO] Make normalize keyPath on key rename request

Posted by GitBox <gi...@apache.org>.
rakeshadr commented on PR #3386:
URL: https://github.com/apache/ozone/pull/3386#issuecomment-1120683850

   Thank you @mukul1987 for the offline discussions about the fix. Please let me know your feedback.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] rakeshadr commented on pull request #3386: HDDS-6708. [FSO] Make normalize keyPath on key rename request

Posted by GitBox <gi...@apache.org>.
rakeshadr commented on PR #3386:
URL: https://github.com/apache/ozone/pull/3386#issuecomment-1122088055

   @mukul1987 
   `ofs://` RootedOzoneFileSystem is already removing the beginning slash at the client side and sending it to the OM. Thats why there is no extra slash issue not occurred with `ofs://`. Say, if user given "/vol-1/buck-1/key-1" then the below logic will construct the path to "vol-1/buck-1/key-1".
   
   [BasicRootedOzoneFileSystem.java#L399 ](https://github.com/apache/ozone/blob/master/hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneFileSystem.java#L399)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] rakeshadr commented on pull request #3386: HDDS-6708. [FSO] Make normalize keyPath on key rename request

Posted by GitBox <gi...@apache.org>.
rakeshadr commented on PR #3386:
URL: https://github.com/apache/ozone/pull/3386#issuecomment-1122658538

   Thanks @mukul1987 for the reviews. I'm merging it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] rakeshadr merged pull request #3386: HDDS-6708. [FSO] Make normalize keyPath on key rename request

Posted by GitBox <gi...@apache.org>.
rakeshadr merged PR #3386:
URL: https://github.com/apache/ozone/pull/3386


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org