[GitHub] [arrow] AlenkaF commented on pull request #35356: GH-34588:[C++][Python] Add a MetaFunction for "dictionary_decode"

["AlenkaF (via GitHub)" <gi...@apache.org>]

AlenkaF commented on PR #35356:
URL: https://github.com/apache/arrow/pull/35356#issuecomment-1612803344

   > Hi, @AlenkaF, I have fixed issues you mentioned. It's stange that there is still a lint error in R but I make no change on R code.
   
   The linter error is actually coming from the C++ part where `dictionary_decode.cc` is missing an ending newline.
   But I agree it is not very clear from the log. Here is the snippet:
   
   ```
   FAILED: CMakeFiles/lint 
   cd /tmp/arrow-lint-r6og459d/cpp-build && /usr/local/bin/python /arrow/cpp/build-support/run_cpplint.py --cpplint_binary /arrow/cpp/build-support/cpplint.py --exclude_globs /arrow/cpp/build-support/lint_exclusions.txt --source_dir /arrow/cpp/src --source_dir /arrow/cpp/examples --source_dir /arrow/cpp/tools --quiet
   /arrow/cpp/src/arrow/compute/dictionary_decode.cc:95:  Could not find a newline character at the end of the file.  [whitespace/ending_newline] [5]
   Done processing /arrow/cpp/src/arrow/compute/dictionary_decode.cc
   Total errors found: 1
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org