You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2022/01/03 20:21:30 UTC

[GitHub] [incubator-heron] nicknezis opened a new pull request #3756: Added Docker to Vagrant VM init script

nicknezis opened a new pull request #3756:
URL: https://github.com/apache/incubator-heron/pull/3756


   Added Docker to the Vagrant init script. This is useful when needing to build docker images from within a Linux environment.
   
   Also updated the NET_PREFIX to adhere to new Vagrant default range. The previous value would error when running `vagrant up`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-heron] surahman commented on a change in pull request #3756: Added Docker to Vagrant VM init script

Posted by GitBox <gi...@apache.org>.
surahman commented on a change in pull request #3756:
URL: https://github.com/apache/incubator-heron/pull/3756#discussion_r777710723



##########
File path: vagrant/Vagrantfile
##########
@@ -16,7 +16,7 @@
 # vi: set ft=ruby :
 
 SECONDARIES=0
-NET_PREFIX="192.168.25."
+NET_PREFIX="192.168.56."

Review comment:
       Just out of curiosity, why the change in IP?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-heron] nicknezis commented on pull request #3756: Added Docker to Vagrant VM init script

Posted by GitBox <gi...@apache.org>.
nicknezis commented on pull request #3756:
URL: https://github.com/apache/incubator-heron/pull/3756#issuecomment-1004343101


   Fixes #3698


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-heron] nicknezis commented on a change in pull request #3756: Added Docker to Vagrant VM init script

Posted by GitBox <gi...@apache.org>.
nicknezis commented on a change in pull request #3756:
URL: https://github.com/apache/incubator-heron/pull/3756#discussion_r777804240



##########
File path: vagrant/Vagrantfile
##########
@@ -16,7 +16,7 @@
 # vi: set ft=ruby :
 
 SECONDARIES=0
-NET_PREFIX="192.168.25."
+NET_PREFIX="192.168.56."

Review comment:
       When I tried to run in Vagrant, I got an error message about it not being in the acceptable subnet range. I think this is a change in Vagrant, so I updated to fit into the new preferred range.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-heron] joshfischer1108 merged pull request #3756: Added Docker to Vagrant VM init script

Posted by GitBox <gi...@apache.org>.
joshfischer1108 merged pull request #3756:
URL: https://github.com/apache/incubator-heron/pull/3756


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-heron] surahman commented on a change in pull request #3756: Added Docker to Vagrant VM init script

Posted by GitBox <gi...@apache.org>.
surahman commented on a change in pull request #3756:
URL: https://github.com/apache/incubator-heron/pull/3756#discussion_r777846967



##########
File path: vagrant/Vagrantfile
##########
@@ -16,7 +16,7 @@
 # vi: set ft=ruby :
 
 SECONDARIES=0
-NET_PREFIX="192.168.25."
+NET_PREFIX="192.168.56."

Review comment:
       Got it, sorry lost sight of the last paragraph in the PR'S initial comment.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org