You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/01/16 22:54:20 UTC
Re: Review Request: Slave Restart (Part Five): Implemented non-child process
monitoring in reaper
> On Dec. 17, 2012, 10:22 p.m., Benjamin Hindman wrote:
> > src/linux/proc.cpp, line 235
> > <https://reviews.apache.org/r/8570/diff/1/?file=238067#file238067line235>
> >
> > Yes, this way we can do testing on OS X.
done. moved to stout/proc.hpp
> On Dec. 17, 2012, 10:22 p.m., Benjamin Hindman wrote:
> > src/tests/slave_recovery_tests.cpp, line 109
> > <https://reviews.apache.org/r/8570/diff/1/?file=238071#file238071line109>
> >
> > You should be able to do 'listener.self()' rather than save the 'mpl' variable.
good to know.
> On Dec. 17, 2012, 10:22 p.m., Benjamin Hindman wrote:
> > src/slave/reaper.cpp, line 93
> > <https://reviews.apache.org/r/8570/diff/1/?file=238069#file238069line93>
> >
> > Ahh, why aren't we checking for an error?
logged a warning.
> On Dec. 17, 2012, 10:22 p.m., Benjamin Hindman wrote:
> > src/slave/reaper.cpp, line 95
> > <https://reviews.apache.org/r/8570/diff/1/?file=238069#file238069line95>
> >
> > Won't this always send a notify even if the pid doesn't exist?
Yes, but this is inside if (!alive.get()), this process terminated.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8570/#review14619
-----------------------------------------------------------
On Dec. 19, 2012, 1:34 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8570/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2012, 1:34 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> Needed this to properly monitor the exit status of re-connected executors, as they will be parented by INIT.
>
>
> Diffs
> -----
>
> src/Makefile.am c94736df660a25b58dc47c07d9c56c3c26152a66
> src/linux/proc.hpp 6c84a73ab1c4d6893390f96eae15422c21001328
> src/linux/proc.cpp 99df77447ddfb07a5febec9ebfed396778665041
> src/slave/reaper.hpp b9aa62daa42bdaa736ade43884982529ba3d4bb1
> src/slave/reaper.cpp c0ee4b4c07fd792bcb39455b666808b712eb32c2
> src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed
> src/tests/reaper_tests.cpp PRE-CREATION
> src/tests/utils.hpp be457117515ee727af101370b26bf9188afb8f45
>
> Diff: https://reviews.apache.org/r/8570/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>