You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/24 16:32:49 UTC

[GitHub] [airflow] jedcunningham commented on pull request #21776: Enable ArgoCD hooks when disabling Helm hooks (#21615)

jedcunningham commented on pull request #21776:
URL: https://github.com/apache/airflow/pull/21776#issuecomment-1050038004


   Yeah, this shouldn't be in the `else` block certainly, as it's not just helm hooks _or_ argocd.
   
   We could entertain adding a `useArgoCDHooks` flag, or add a section in the documentation about adding annotations in `jobAnnotations`. And yes, `jobAnnotations` for the migration and create user jobs is all thats needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org