[GitHub] [bookkeeper] merlimat commented on a diff in pull request #3837: Group and flush add-responses after journal sync

["merlimat (via GitHub)" <gi...@apache.org>]

merlimat commented on code in PR #3837:
URL: https://github.com/apache/bookkeeper/pull/3837#discussion_r1127263449


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java:
##########
@@ -1093,6 +1100,10 @@ journalFormatVersionToWrite, getBufferedChannelBuilder(),
                                     numEntriesToFlush--;
                                     entry.run();
                                 }
+
+                                if (forceWriteThread.requestProcessor != null) {
+                                    forceWriteThread.requestProcessor.flushPendingResponses();
+                                }

Review Comment:
   The flush would be very fast though. It's only posting an event on the channel group, not writing the actuals responses on the channels.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org