You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/07/27 18:53:11 UTC
[GitHub] [spark] MaxGekk opened a new pull request, #37323: [WIP][SQL] Fix passing of message parameters to `InvalidUDFClassException`
MaxGekk opened a new pull request, #37323:
URL: https://github.com/apache/spark/pull/37323
### What changes were proposed in this pull request?
In the PR, I propose to pass `messageParameters` to `AnalysisException` from `InvalidUDFClassException`.
### Why are the changes needed?
To fix a bug and provide actual message parameters to users.
### Does this PR introduce _any_ user-facing change?
Yes. After the changes, users receive non-empty message parameters.
### How was this patch tested?
By running the modified test suite:
```
$ build/sbt "sql/testOnly *QueryCompilationErrorsSuite"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #37323: [SPARK-39899][SQL] Fix passing of message parameters to `InvalidUDFClassException`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #37323:
URL: https://github.com/apache/spark/pull/37323#issuecomment-1197654064
I think the test failure is not related to the changes:
```
Exception: java.util.concurrent.TimeoutException: Futures timed out after [2 minutes]
Failed to capture next expected output "Unclosed bracketed comment" within 2 minutes.
```
I re-ran the test locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #37323: [SPARK-39899][SQL] Fix passing of message parameters to `InvalidUDFClassException`
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #37323: [SPARK-39899][SQL] Fix passing of message parameters to `InvalidUDFClassException`
URL: https://github.com/apache/spark/pull/37323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #37323: [SPARK-39899][SQL] Fix passing of message parameters to `InvalidUDFClassException`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #37323:
URL: https://github.com/apache/spark/pull/37323#issuecomment-1197654429
Merging to master. Thank you, @cloud-fan for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #37323: [SPARK-39899][SQL] Fix passing of message parameters to `InvalidUDFClassException`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #37323:
URL: https://github.com/apache/spark/pull/37323#issuecomment-1197248503
@cloud-fan @srielau @AngersZhuuuu @ivoson Please, have a look at the PR since you touched `InvalidUDFClassException `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org