You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Aleksandr Kovalenko <ak...@hortonworks.com> on 2014/04/15 14:47:42 UTC

Review Request 20369: Create configs tab for Flume service

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20369/
-----------------------------------------------------------

Review request for Ambari and Andriy Babiichuk.


Bugs: AMBARI-5473
    https://issues.apache.org/jira/browse/AMBARI-5473


Repository: ambari


Description
-------

Flume service should have a configs tab. In there will be only 1 config with name 'flume-agent.sh'. Its value will be a text-area. This will be put in configuration of type flume-agent. 

We need to ensure that config-groups works as expected with this new config.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/configuration/flume-agent.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/metainfo.xml 8e3dca0 
  ambari-web/app/assets/data/clusters/tags_and_groups.json d4e1f3a 
  ambari-web/app/assets/data/configurations/cluster_level_configs.json 267c4f6 
  ambari-web/app/controllers/wizard.js 61de2bd 
  ambari-web/app/controllers/wizard/step8_controller.js 5ce4555 
  ambari-web/app/data/HDP2/site_properties.js dedd4ca 
  ambari-web/app/data/service_configs.js 2ea1958 
  ambari-web/app/models/service.js 26d1def 
  ambari-web/app/utils/config.js 90ab28f 

Diff: https://reviews.apache.org/r/20369/diff/


Testing
-------


Thanks,

Aleksandr Kovalenko

Re: Review Request 20369: Create configs tab for Flume service

Posted by Andriy Babiichuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20369/#review40384
-----------------------------------------------------------

Ship it!


Ship It!

- Andriy Babiichuk


On April 15, 2014, 12:47 p.m., Aleksandr Kovalenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20369/
> -----------------------------------------------------------
> 
> (Updated April 15, 2014, 12:47 p.m.)
> 
> 
> Review request for Ambari and Andriy Babiichuk.
> 
> 
> Bugs: AMBARI-5473
>     https://issues.apache.org/jira/browse/AMBARI-5473
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Flume service should have a configs tab. In there will be only 1 config with name 'flume-agent.sh'. Its value will be a text-area. This will be put in configuration of type flume-agent. 
> 
> We need to ensure that config-groups works as expected with this new config.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/configuration/flume-agent.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/metainfo.xml 8e3dca0 
>   ambari-web/app/assets/data/clusters/tags_and_groups.json d4e1f3a 
>   ambari-web/app/assets/data/configurations/cluster_level_configs.json 267c4f6 
>   ambari-web/app/controllers/wizard.js 61de2bd 
>   ambari-web/app/controllers/wizard/step8_controller.js 5ce4555 
>   ambari-web/app/data/HDP2/site_properties.js dedd4ca 
>   ambari-web/app/data/service_configs.js 2ea1958 
>   ambari-web/app/models/service.js 26d1def 
>   ambari-web/app/utils/config.js 90ab28f 
> 
> Diff: https://reviews.apache.org/r/20369/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleksandr Kovalenko
> 
>