You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hugegraph.apache.org by "caicancai (via GitHub)" <gi...@apache.org> on 2023/12/20 07:11:05 UTC
[PR] chore: add license link [incubator-hugegraph]
caicancai opened a new pull request, #2398:
URL: https://github.com/apache/incubator-hugegraph/pull/2398
<!--
Thank you very much for contributing to Apache HugeGraph, we are happy that you want to help us improve it!
Here are some tips for you:
1. If this is your first time, please read the [contributing guidelines](https://github.com/apache/hugegraph/blob/master/CONTRIBUTING.md)
2. If a PR fix/close an issue, type the message "close xxx" (xxx is the link of related
issue) in the content, GitHub will auto link it (Required)
3. Name the PR title in "Google Commit Format", start with "feat | fix | perf | refactor | doc | chore",
such like: "feat(core): support the PageRank algorithm" or "fix: wrong break in the compute loop" (module is optional)
skip it if you are unsure about which is the best component.
4. One PR address one issue, better not to mix up multiple issues.
5. Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]` (or click it directly after
published)
-->
## Purpose of the PR
- close #xxx <!-- or use "fix #xxx", "xxx" is the ID-link of related issue, e.g: close #1024 -->
<!--
Please explain more context in this section, clarify why the changes are needed.
e.g:
- If you propose a new API, clarify the use case for a new API.
- If you fix a bug, you can clarify why it is a bug, and should be associated with an issue.
-->
## Main Changes
<!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. These change logs are helpful for better ant faster reviews.)
For example:
- If you introduce a new feature, please show detailed design here or add the link of design documentation.
- If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
- If there is a discussion in the mailing list, please add the link. -->
## Verifying these changes
<!-- Please pick the proper options below -->
- [ ] Trivial rework / code cleanup without any test coverage. (No Need)
- [ ] Already covered by existing tests, such as *(please modify tests here)*.
- [ ] Need tests and can be verified as follows:
- xxx
## Does this PR potentially affect the following parts?
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] Nope
- [ ] Dependencies (add/update license info) <!-- Don't forget to add/update the info in "LICENSE" & "NOTICE" files (both in root & dist module) -->
- [ ] Modify configurations
- [ ] The public API
- [ ] Other affects (typed here)
## Documentation Status
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `Doc - TODO` <!-- Your PR changes impact docs and you will update later -->
- [ ] `Doc - Done` <!-- Related docs have been already added or updated -->
- [ ] `Doc - No Need` <!-- Your PR changes don't impact/need docs -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] chore: add license link [incubator-hugegraph]
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #2398:
URL: https://github.com/apache/incubator-hugegraph/pull/2398#discussion_r1432339655
##########
README.md:
##########
@@ -63,7 +63,7 @@ You can visit [doc page](https://hugegraph.apache.org/docs/quickstart/hugegraph-
## License
-HugeGraph is licensed under Apache 2.0 License.
+HugeGraph is licensed under [Apache 2.0 License](http://www.apache.org/licenses/LICENSE-2.0).
Review Comment:
Thanks but maybe use our modified LICENSE file is better?
https://github.com/apache/incubator-hugegraph/blob/master/LICENSE
u could use abs path or relative path for it (both fine)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] chore: add license link [incubator-hugegraph]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2398:
URL: https://github.com/apache/incubator-hugegraph/pull/2398#issuecomment-1863979074
## [Codecov](https://app.codecov.io/gh/apache/incubator-hugegraph/pull/2398?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`7635c67`)](https://app.codecov.io/gh/apache/incubator-hugegraph/commit/7635c67865e5bd66958592572ce0557b24aa0718?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 65.59% compared to head [(`dae56f2`)](https://app.codecov.io/gh/apache/incubator-hugegraph/pull/2398?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 48.29%.
> :exclamation: Current head dae56f2 differs from pull request most recent head 6da182f. Consider uploading reports for the commit 6da182f to get more accurate results
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #2398 +/- ##
=============================================
- Coverage 65.59% 48.29% -17.30%
+ Complexity 587 272 -315
=============================================
Files 511 511
Lines 42590 42587 -3
Branches 5941 5928 -13
=============================================
- Hits 27936 20567 -7369
- Misses 11840 19699 +7859
+ Partials 2814 2321 -493
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-hugegraph/pull/2398?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] chore: add license link [incubator-hugegraph]
Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on PR #2398:
URL: https://github.com/apache/incubator-hugegraph/pull/2398#issuecomment-1874942169
@imbajin Good to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] chore: add license link [incubator-hugegraph]
Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on code in PR #2398:
URL: https://github.com/apache/incubator-hugegraph/pull/2398#discussion_r1432349267
##########
README.md:
##########
@@ -63,7 +63,7 @@ You can visit [doc page](https://hugegraph.apache.org/docs/quickstart/hugegraph-
## License
-HugeGraph is licensed under Apache 2.0 License.
+HugeGraph is licensed under [Apache 2.0 License](https://github.com/apache/incubator-hugegraph/blob/master/LICENSE).
Review Comment:
HugeGraph is licensed under [Apache 2.0 License](LICENSE).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] chore: add license link [incubator-hugegraph]
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #2398:
URL: https://github.com/apache/incubator-hugegraph/pull/2398#discussion_r1432345734
##########
README.md:
##########
@@ -63,7 +63,7 @@ You can visit [doc page](https://hugegraph.apache.org/docs/quickstart/hugegraph-
## License
-HugeGraph is licensed under Apache 2.0 License.
+HugeGraph is licensed under [Apache 2.0 License](https://github.com/apache/incubator-hugegraph/blob/master/LICENSE).
Review Comment:
```suggestion
HugeGraph is licensed under [Apache 2.0 License](./LICENSE).
```
One problem that comes to mind is that **different versions/branch** of the `LICENSE` should be **kept relatively consistent**, rather than **fixed**, and it does seem that it would be better to use a **relative path** (so that the LICENSE file is also in the same version?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] chore: add license link [incubator-hugegraph]
Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on code in PR #2398:
URL: https://github.com/apache/incubator-hugegraph/pull/2398#discussion_r1432349267
##########
README.md:
##########
@@ -63,7 +63,7 @@ You can visit [doc page](https://hugegraph.apache.org/docs/quickstart/hugegraph-
## License
-HugeGraph is licensed under Apache 2.0 License.
+HugeGraph is licensed under [Apache 2.0 License](https://github.com/apache/incubator-hugegraph/blob/master/LICENSE).
Review Comment:
HugeGraph is licensed under [Apache 2.0 License](LICENSE).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] chore: add license link [incubator-hugegraph]
Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on code in PR #2398:
URL: https://github.com/apache/incubator-hugegraph/pull/2398#discussion_r1432350048
##########
README.md:
##########
@@ -63,7 +63,7 @@ You can visit [doc page](https://hugegraph.apache.org/docs/quickstart/hugegraph-
## License
-HugeGraph is licensed under Apache 2.0 License.
+HugeGraph is licensed under [Apache 2.0 License](https://github.com/apache/incubator-hugegraph/blob/master/LICENSE).
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] chore: add license link [incubator-hugegraph]
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin merged PR #2398:
URL: https://github.com/apache/incubator-hugegraph/pull/2398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] chore: add license link [incubator-hugegraph]
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #2398:
URL: https://github.com/apache/incubator-hugegraph/pull/2398#discussion_r1432339655
##########
README.md:
##########
@@ -63,7 +63,7 @@ You can visit [doc page](https://hugegraph.apache.org/docs/quickstart/hugegraph-
## License
-HugeGraph is licensed under Apache 2.0 License.
+HugeGraph is licensed under [Apache 2.0 License](http://www.apache.org/licenses/LICENSE-2.0).
Review Comment:
Thanks but maybe use our current file is better?
https://github.com/apache/incubator-hugegraph/blob/master/LICENSE
u could use abs path or relative path for it (both fine)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] chore: add license link [incubator-hugegraph]
Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on code in PR #2398:
URL: https://github.com/apache/incubator-hugegraph/pull/2398#discussion_r1432342490
##########
README.md:
##########
@@ -63,7 +63,7 @@ You can visit [doc page](https://hugegraph.apache.org/docs/quickstart/hugegraph-
## License
-HugeGraph is licensed under Apache 2.0 License.
+HugeGraph is licensed under [Apache 2.0 License](http://www.apache.org/licenses/LICENSE-2.0).
Review Comment:
thank you, done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org