You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Jeff Genender (JIRA)" <de...@geronimo.apache.org> on 2006/07/27 21:25:14 UTC
[jira] Created: (GERONIMO-2237) Filtering of springframework.org in
TomcatDeployer plan creates CNF Exceptions in Ears
Filtering of springframework.org in TomcatDeployer plan creates CNF Exceptions in Ears
--------------------------------------------------------------------------------------
Key: GERONIMO-2237
URL: http://issues.apache.org/jira/browse/GERONIMO-2237
Project: Geronimo
Issue Type: Bug
Security Level: public (Regular issues)
Components: Tomcat
Affects Versions: 1.1.1
Reporter: Jeff Genender
Priority: Blocker
Fix For: 1.1.1
Filtering of springframework.org in TomcatDeployer plan creates ClassNotFound Exceptions in Ears when it tries to use a component that uses Spring in the EAR. We originally filtered this to automatically prevent Spring clashing with a server based Spring (from 1.0). This was fine for wars but when used iun an ear, the web container is blocked from using the EAR version. I recommend we remove these filters as SPrin is not usable in an EAR. Recommended patch for configs/tomcat-deployer:
Index: src/plan/plan.xml
===================================================================
--- src/plan/plan.xml (revision 426203)
+++ src/plan/plan.xml (working copy)
@@ -46,10 +46,7 @@
<type>car</type>
</dependency>
</dependencies>
- <hidden-classes>
- <filter>antlr.</filter>
- <filter>org.springframework.</filter>
- </hidden-classes>
+ <hidden-classes/>
<non-overridable-classes>
<filter>java.</filter>
<filter>javax.</filter>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2237) Filtering of springframework.org
in TomcatDeployer plan creates CNF Exceptions in Ears
Posted by "Jeff Genender (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2237?page=comments#action_12423902 ]
Jeff Genender commented on GERONIMO-2237:
-----------------------------------------
We don't have Spring in the server any more so removing the filters should be a non-event. It won't affect anything since the server does not depend on the jars.
> Filtering of springframework.org in TomcatDeployer plan creates CNF Exceptions in Ears
> --------------------------------------------------------------------------------------
>
> Key: GERONIMO-2237
> URL: http://issues.apache.org/jira/browse/GERONIMO-2237
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Tomcat
> Affects Versions: 1.1
> Reporter: Jeff Genender
> Priority: Blocker
> Fix For: 1.1.1
>
>
> Filtering of springframework.org in TomcatDeployer plan creates ClassNotFound Exceptions in Ears when it tries to use a component that uses Spring in the EAR. We originally filtered this to automatically prevent Spring clashing with a server based Spring (from 1.0). This was fine for wars but when used iun an ear, the web container is blocked from using the EAR version. I recommend we remove these filters as SPrin is not usable in an EAR. Recommended patch for configs/tomcat-deployer:
> Index: src/plan/plan.xml
> ===================================================================
> --- src/plan/plan.xml (revision 426203)
> +++ src/plan/plan.xml (working copy)
> @@ -46,10 +46,7 @@
> <type>car</type>
> </dependency>
> </dependencies>
> - <hidden-classes>
> - <filter>antlr.</filter>
> - <filter>org.springframework.</filter>
> - </hidden-classes>
> + <hidden-classes/>
> <non-overridable-classes>
> <filter>java.</filter>
> <filter>javax.</filter>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2237) Filtering of springframework.org
in TomcatDeployer plan creates CNF Exceptions in Ears
Posted by "Jeff Genender (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2237?page=comments#action_12423912 ]
Jeff Genender commented on GERONIMO-2237:
-----------------------------------------
I committed the change. I will leave this open for a few days for discussion, but this requires a much bigger discussion on the lists with respect to the true problem, rather than the treatment with filters.
Sending src/plan/plan.xml
Transmitting file data .
Committed revision 426232.
> Filtering of springframework.org in TomcatDeployer plan creates CNF Exceptions in Ears
> --------------------------------------------------------------------------------------
>
> Key: GERONIMO-2237
> URL: http://issues.apache.org/jira/browse/GERONIMO-2237
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Tomcat
> Affects Versions: 1.1
> Reporter: Jeff Genender
> Priority: Blocker
> Fix For: 1.1.1
>
>
> Filtering of springframework.org in TomcatDeployer plan creates ClassNotFound Exceptions in Ears when it tries to use a component that uses Spring in the EAR. We originally filtered this to automatically prevent Spring clashing with a server based Spring (from 1.0). This was fine for wars but when used iun an ear, the web container is blocked from using the EAR version. I recommend we remove these filters as SPrin is not usable in an EAR. Recommended patch for configs/tomcat-deployer:
> Index: src/plan/plan.xml
> ===================================================================
> --- src/plan/plan.xml (revision 426203)
> +++ src/plan/plan.xml (working copy)
> @@ -46,10 +46,7 @@
> <type>car</type>
> </dependency>
> </dependencies>
> - <hidden-classes>
> - <filter>antlr.</filter>
> - <filter>org.springframework.</filter>
> - </hidden-classes>
> + <hidden-classes/>
> <non-overridable-classes>
> <filter>java.</filter>
> <filter>javax.</filter>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2237) Filtering of springframework.org
in TomcatDeployer plan creates CNF Exceptions in Ears
Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2237?page=comments#action_12423901 ]
Aaron Mulder commented on GERONIMO-2237:
----------------------------------------
The problem we want to avoid is requiring every Spring user to have a geronimo-web.xml just to exclude Spring.
I'm open to other ways of doing this (like adding the filter at the EAR level instead of the WAR level if the WAR is in an EAR), but I don't want to go back to every Spring WAR needing geronimo-web.xml.
Best of all would be to get Spring out of the parent hierarchy of web apps so this problem just went away.
> Filtering of springframework.org in TomcatDeployer plan creates CNF Exceptions in Ears
> --------------------------------------------------------------------------------------
>
> Key: GERONIMO-2237
> URL: http://issues.apache.org/jira/browse/GERONIMO-2237
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Tomcat
> Affects Versions: 1.1
> Reporter: Jeff Genender
> Priority: Blocker
> Fix For: 1.1.1
>
>
> Filtering of springframework.org in TomcatDeployer plan creates ClassNotFound Exceptions in Ears when it tries to use a component that uses Spring in the EAR. We originally filtered this to automatically prevent Spring clashing with a server based Spring (from 1.0). This was fine for wars but when used iun an ear, the web container is blocked from using the EAR version. I recommend we remove these filters as SPrin is not usable in an EAR. Recommended patch for configs/tomcat-deployer:
> Index: src/plan/plan.xml
> ===================================================================
> --- src/plan/plan.xml (revision 426203)
> +++ src/plan/plan.xml (working copy)
> @@ -46,10 +46,7 @@
> <type>car</type>
> </dependency>
> </dependencies>
> - <hidden-classes>
> - <filter>antlr.</filter>
> - <filter>org.springframework.</filter>
> - </hidden-classes>
> + <hidden-classes/>
> <non-overridable-classes>
> <filter>java.</filter>
> <filter>javax.</filter>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-2237) Filtering of springframework.org in
TomcatDeployer plan creates CNF Exceptions in Ears
Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2237?page=all ]
Aaron Mulder updated GERONIMO-2237:
-----------------------------------
Affects Version/s: 1.1
(was: 1.1.1)
> Filtering of springframework.org in TomcatDeployer plan creates CNF Exceptions in Ears
> --------------------------------------------------------------------------------------
>
> Key: GERONIMO-2237
> URL: http://issues.apache.org/jira/browse/GERONIMO-2237
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Tomcat
> Affects Versions: 1.1
> Reporter: Jeff Genender
> Priority: Blocker
> Fix For: 1.1.1
>
>
> Filtering of springframework.org in TomcatDeployer plan creates ClassNotFound Exceptions in Ears when it tries to use a component that uses Spring in the EAR. We originally filtered this to automatically prevent Spring clashing with a server based Spring (from 1.0). This was fine for wars but when used iun an ear, the web container is blocked from using the EAR version. I recommend we remove these filters as SPrin is not usable in an EAR. Recommended patch for configs/tomcat-deployer:
> Index: src/plan/plan.xml
> ===================================================================
> --- src/plan/plan.xml (revision 426203)
> +++ src/plan/plan.xml (working copy)
> @@ -46,10 +46,7 @@
> <type>car</type>
> </dependency>
> </dependencies>
> - <hidden-classes>
> - <filter>antlr.</filter>
> - <filter>org.springframework.</filter>
> - </hidden-classes>
> + <hidden-classes/>
> <non-overridable-classes>
> <filter>java.</filter>
> <filter>javax.</filter>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2237) Filtering of springframework.org
in TomcatDeployer plan creates CNF Exceptions in Ears
Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2237?page=comments#action_12425558 ]
Aaron Mulder commented on GERONIMO-2237:
----------------------------------------
I tested a web application WAR using Spring 1 and Hibernate 2 with the branches/1.1.1 build and it worked (without any adjustments to the <environment> element). So it seems like Spring/Hibernate apps currently work OK in 1.1.1. However, I did not test an EAR.
> Filtering of springframework.org in TomcatDeployer plan creates CNF Exceptions in Ears
> --------------------------------------------------------------------------------------
>
> Key: GERONIMO-2237
> URL: http://issues.apache.org/jira/browse/GERONIMO-2237
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Tomcat
> Affects Versions: 1.1
> Reporter: Jeff Genender
> Priority: Blocker
> Fix For: 1.1.1
>
>
> Filtering of springframework.org in TomcatDeployer plan creates ClassNotFound Exceptions in Ears when it tries to use a component that uses Spring in the EAR. We originally filtered this to automatically prevent Spring clashing with a server based Spring (from 1.0). This was fine for wars but when used iun an ear, the web container is blocked from using the EAR version. I recommend we remove these filters as SPrin is not usable in an EAR. Recommended patch for configs/tomcat-deployer:
> Index: src/plan/plan.xml
> ===================================================================
> --- src/plan/plan.xml (revision 426203)
> +++ src/plan/plan.xml (working copy)
> @@ -46,10 +46,7 @@
> <type>car</type>
> </dependency>
> </dependencies>
> - <hidden-classes>
> - <filter>antlr.</filter>
> - <filter>org.springframework.</filter>
> - </hidden-classes>
> + <hidden-classes/>
> <non-overridable-classes>
> <filter>java.</filter>
> <filter>javax.</filter>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (GERONIMO-2237) Filtering of springframework.org in
TomcatDeployer plan creates CNF Exceptions in Ears
Posted by "Jeff Genender (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2237?page=all ]
Jeff Genender closed GERONIMO-2237.
-----------------------------------
Fix Version/s: 1.2
Resolution: Fixed
Was left open for discussion. Will close as it seems to have been fine.
> Filtering of springframework.org in TomcatDeployer plan creates CNF Exceptions in Ears
> --------------------------------------------------------------------------------------
>
> Key: GERONIMO-2237
> URL: http://issues.apache.org/jira/browse/GERONIMO-2237
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Tomcat
> Affects Versions: 1.1
> Reporter: Jeff Genender
> Priority: Blocker
> Fix For: 1.1.1, 1.2
>
>
> Filtering of springframework.org in TomcatDeployer plan creates ClassNotFound Exceptions in Ears when it tries to use a component that uses Spring in the EAR. We originally filtered this to automatically prevent Spring clashing with a server based Spring (from 1.0). This was fine for wars but when used iun an ear, the web container is blocked from using the EAR version. I recommend we remove these filters as SPrin is not usable in an EAR. Recommended patch for configs/tomcat-deployer:
> Index: src/plan/plan.xml
> ===================================================================
> --- src/plan/plan.xml (revision 426203)
> +++ src/plan/plan.xml (working copy)
> @@ -46,10 +46,7 @@
> <type>car</type>
> </dependency>
> </dependencies>
> - <hidden-classes>
> - <filter>antlr.</filter>
> - <filter>org.springframework.</filter>
> - </hidden-classes>
> + <hidden-classes/>
> <non-overridable-classes>
> <filter>java.</filter>
> <filter>javax.</filter>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2237) Filtering of springframework.org
in TomcatDeployer plan creates CNF Exceptions in Ears
Posted by "Matt Hogstrom (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2237?page=comments#action_12423981 ]
Matt Hogstrom commented on GERONIMO-2237:
-----------------------------------------
This makes sense for 1.1.1. I think Dain's changes will make us implement Aaron's suggestion later but that is another JIRA.
> Filtering of springframework.org in TomcatDeployer plan creates CNF Exceptions in Ears
> --------------------------------------------------------------------------------------
>
> Key: GERONIMO-2237
> URL: http://issues.apache.org/jira/browse/GERONIMO-2237
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Tomcat
> Affects Versions: 1.1
> Reporter: Jeff Genender
> Priority: Blocker
> Fix For: 1.1.1
>
>
> Filtering of springframework.org in TomcatDeployer plan creates ClassNotFound Exceptions in Ears when it tries to use a component that uses Spring in the EAR. We originally filtered this to automatically prevent Spring clashing with a server based Spring (from 1.0). This was fine for wars but when used iun an ear, the web container is blocked from using the EAR version. I recommend we remove these filters as SPrin is not usable in an EAR. Recommended patch for configs/tomcat-deployer:
> Index: src/plan/plan.xml
> ===================================================================
> --- src/plan/plan.xml (revision 426203)
> +++ src/plan/plan.xml (working copy)
> @@ -46,10 +46,7 @@
> <type>car</type>
> </dependency>
> </dependencies>
> - <hidden-classes>
> - <filter>antlr.</filter>
> - <filter>org.springframework.</filter>
> - </hidden-classes>
> + <hidden-classes/>
> <non-overridable-classes>
> <filter>java.</filter>
> <filter>javax.</filter>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2237) Filtering of springframework.org
in TomcatDeployer plan creates CNF Exceptions in Ears
Posted by "Jeff Genender (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2237?page=comments#action_12423911 ]
Jeff Genender commented on GERONIMO-2237:
-----------------------------------------
"Best of all would be to get Spring out of the parent hierarchy of web apps so this problem just went away."
Its out...it was out since 1.1 release.
The patch has no effect since Spring was removed from the server in 1.1. The filter is not even in Jetty AFAICT. This is a bigger bug than having to place the filters in the DDs (which isn't necessary). I move that we apply the patch and fix the classloaders for 1.2, which is the real problem IMHO.
> Filtering of springframework.org in TomcatDeployer plan creates CNF Exceptions in Ears
> --------------------------------------------------------------------------------------
>
> Key: GERONIMO-2237
> URL: http://issues.apache.org/jira/browse/GERONIMO-2237
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Tomcat
> Affects Versions: 1.1
> Reporter: Jeff Genender
> Priority: Blocker
> Fix For: 1.1.1
>
>
> Filtering of springframework.org in TomcatDeployer plan creates ClassNotFound Exceptions in Ears when it tries to use a component that uses Spring in the EAR. We originally filtered this to automatically prevent Spring clashing with a server based Spring (from 1.0). This was fine for wars but when used iun an ear, the web container is blocked from using the EAR version. I recommend we remove these filters as SPrin is not usable in an EAR. Recommended patch for configs/tomcat-deployer:
> Index: src/plan/plan.xml
> ===================================================================
> --- src/plan/plan.xml (revision 426203)
> +++ src/plan/plan.xml (working copy)
> @@ -46,10 +46,7 @@
> <type>car</type>
> </dependency>
> </dependencies>
> - <hidden-classes>
> - <filter>antlr.</filter>
> - <filter>org.springframework.</filter>
> - </hidden-classes>
> + <hidden-classes/>
> <non-overridable-classes>
> <filter>java.</filter>
> <filter>javax.</filter>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2237) Filtering of springframework.org
in TomcatDeployer plan creates CNF Exceptions in Ears
Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2237?page=comments#action_12426250 ]
Aaron Mulder commented on GERONIMO-2237:
----------------------------------------
If the fix was applied to 1.1.1, why is this issue still open? Jeff, are you waiting for something before closing it?
> Filtering of springframework.org in TomcatDeployer plan creates CNF Exceptions in Ears
> --------------------------------------------------------------------------------------
>
> Key: GERONIMO-2237
> URL: http://issues.apache.org/jira/browse/GERONIMO-2237
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Tomcat
> Affects Versions: 1.1
> Reporter: Jeff Genender
> Priority: Blocker
> Fix For: 1.1.1
>
>
> Filtering of springframework.org in TomcatDeployer plan creates ClassNotFound Exceptions in Ears when it tries to use a component that uses Spring in the EAR. We originally filtered this to automatically prevent Spring clashing with a server based Spring (from 1.0). This was fine for wars but when used iun an ear, the web container is blocked from using the EAR version. I recommend we remove these filters as SPrin is not usable in an EAR. Recommended patch for configs/tomcat-deployer:
> Index: src/plan/plan.xml
> ===================================================================
> --- src/plan/plan.xml (revision 426203)
> +++ src/plan/plan.xml (working copy)
> @@ -46,10 +46,7 @@
> <type>car</type>
> </dependency>
> </dependencies>
> - <hidden-classes>
> - <filter>antlr.</filter>
> - <filter>org.springframework.</filter>
> - </hidden-classes>
> + <hidden-classes/>
> <non-overridable-classes>
> <filter>java.</filter>
> <filter>javax.</filter>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira