You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/02/26 15:57:18 UTC
[jira] [Commented] (FLINK-3521) Make Iterable part of method
signature for WindowFunction
[ https://issues.apache.org/jira/browse/FLINK-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169147#comment-15169147 ]
ASF GitHub Bot commented on FLINK-3521:
---------------------------------------
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/1723
[FLINK-3521] Make Iterable part of method signature for WindowFunction
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink window-change-sig
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1723.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1723
----
commit 33b382c8603667b5c625195afba1355410035d15
Author: Aljoscha Krettek <al...@gmail.com>
Date: 2016-02-26T14:19:50Z
[FLINK-3521] Make Iterable part of method signature for WindowFunction
----
> Make Iterable part of method signature for WindowFunction
> ---------------------------------------------------------
>
> Key: FLINK-3521
> URL: https://issues.apache.org/jira/browse/FLINK-3521
> Project: Flink
> Issue Type: Improvement
> Components: Streaming
> Reporter: Aljoscha Krettek
> Assignee: Aljoscha Krettek
> Priority: Blocker
>
> After discussion with [~StephanEwen],[~rmetzger], [~fhueske] it was decided that the signature of WindowFunction should be changed.
> Right now, the signature is {{WindowFunction<IN, OUT, KEY, WINDOW>}}. With the decision of whether the input is an {{Iterable}} nor not residing in the signature of the method on {{WindowedStream}}, for example:
> - {{WindowedStream.apply(WindowFunction<Iterable<IN>>, OUT, KEY, WINDOW>}}
> - {{WindowedStream.apply(ReduceFunction, WindowFunction<IN, OUT, KEY, WINDOW>}}
> The {{Iterable<>}} should be moved into the signature of the {{apply}} method, so that it is:
> {{void apply(KEY key, W window, Iterable<IN> input, Collector<OUT> out)}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)