You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2018/06/01 01:44:33 UTC
Re: Review Request 67065: Added a new stout utility header file which
interfaces with libarchive.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67065/#review204155
-----------------------------------------------------------
3rdparty/stout/include/stout/archiver.hpp
Lines 20 (patched)
<https://reviews.apache.org/r/67065/#comment286542>
This definition should go into the CMake file(s):
```
# This is a definition that only has an effect on Windows and is necessary
# when building a static libarchive instead of a DLL.
target_compile_definitions(libarchive PUBLIC LIBARCHIVE_STATIC)
```
3rdparty/stout/include/stout/archiver.hpp
Lines 36-58 (patched)
<https://reviews.apache.org/r/67065/#comment286557>
We might not need to have a helper for error handling. If you treat all `result <= ARCHIVE_WARN` as an error, you can get the roughly same behavior (minus the WARNING logs).
3rdparty/stout/include/stout/archiver.hpp
Lines 124-127 (patched)
<https://reviews.apache.org/r/67065/#comment286546>
This error check could be made more explicit:
```
if (result != ARCHIVE_OK) { ... }
```
- Joseph Wu
On May 30, 2018, 1:29 p.m., John Kordich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67065/
> -----------------------------------------------------------
>
> (Updated May 30, 2018, 1:29 p.m.)
>
>
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.
>
>
> Bugs: MESOS-8064
> https://issues.apache.org/jira/browse/MESOS-8064
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This archiver utility can be invoked to extract a compressed or
> uncompressed archive with several different supported formats.
>
>
> Diffs
> -----
>
> 3rdparty/stout/CMakeLists.txt 24a1f0acbee8a464fcc5159cf41d7e93aa8148fc
> 3rdparty/stout/Makefile.am ef22a02a8a11326c6af19eb11d79eb82ff7861da
> 3rdparty/stout/include/Makefile.am e0097c438a62a9802d6e60c78493bf97333f20ed
> 3rdparty/stout/include/stout/archiver.hpp PRE-CREATION
> 3rdparty/stout/tests/CMakeLists.txt 86111a8709cab709ba1bf844043d3a1da07b6241
> 3rdparty/stout/tests/archiver_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/67065/diff/5/
>
>
> Testing
> -------
>
> I've built on Windows with CMake and have run all tests, which all pass.
> I've also built on Linux with both the autotools build and cmake build and have run all tests, which all pass.
>
>
> Thanks,
>
> John Kordich
>
>