You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2015/11/30 12:40:49 UTC
[GitHub] couchdb-fauxton pull request: build: build less faster & without g...
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/586
build: build less faster & without grunt
this slices our first build step out of the monolithic grunt build.
improvements:
- faster less build
- no useless css files for modules in debug folder, just one
`index.css`
- multiple targets possible (so we don't need to build from
`dist/debug` in the future
performance for less build & concat:
```
old:
- 762ms -- 757ms + 5ms (separate concat)
new:
- 597ms
```
why is it faster?
1. previous buildstep wrote css files on the disk to read & concat
it later
2. grunt.readfile / grunt.readjson are slow compared to the native
require function which also supports caching
needs node 4.x like our travis builds
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton css-less-try2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/586.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #586
----
commit bfda5a573fe66fe4ae27cd02d512c8603f97ea26
Author: Robert Kowalski <ro...@apache.org>
Date: 2015-11-20T15:33:06Z
build: build less faster & without grunt
this slices our first build step out of the monolithic grunt build.
improvements:
- faster less build
- no useless css files for modules in debug folder, just one
`index.css`
- multiple targets possible (so we don't need to build from
`dist/debug` in the future
performance for less build & concat:
```
old:
- 762ms -- 757ms + 5ms (separate concat)
new:
- 597ms
```
why is it faster?
1. previous buildstep wrote css files on the disk to read & concat
it later
2. grunt.readfile / grunt.readjson are slow compared to the native
require function which also supports caching
needs node 4.x like our travis builds
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: build: build less/css faster & witho...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/586#issuecomment-161908415
merged as a0c0b166d85d5e3db30342949290b33107e9304e - yay!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: build: build less/css faster & witho...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/586#discussion_r46387675
--- Diff: build-helper/less.js ---
@@ -0,0 +1,69 @@
+'use strict';
--- End diff --
yes, some ES6 features like const just work in strict mode right now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: build: build less/css faster & witho...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/586
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: build: build less/css faster & witho...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/586#discussion_r46313735
--- Diff: build-helper/less.js ---
@@ -0,0 +1,69 @@
+'use strict';
--- End diff --
This necessary? Just curious - I thought all parsing of the JS files was jshinted - or is that only the application code?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: build: build less/css faster & witho...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/586#issuecomment-161050423
This looks great, Robert. Works fine. Nice to see some ES6 code in Fauxton. :+1: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---