You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/05/14 08:57:37 UTC

[GitHub] [camel-k] orpiske commented on a change in pull request #2290: Configure kubernetes to use structured log

orpiske commented on a change in pull request #2290:
URL: https://github.com/apache/camel-k/pull/2290#discussion_r632387150



##########
File path: e2e/common/operator_metrics_test.go
##########
@@ -81,14 +81,19 @@ func TestMetrics(t *testing.T) {
 				AddStep(MatchFields(IgnoreExtras, Fields{
 					"LoggerName":  Equal("camel-k.controller.build"),
 					"Message":     Equal("Build state transition"),
-					"Phase":       Equal(string(v1.BuildPhasePending)),
+					"Phase":       MatchFields(IgnoreExtras,

Review comment:
       I don't think so. This seemed as one of the things causing this test to fail, since the Phase element on the LogEntry structure was changed (because the logs are not normalized themselves, having either strings integers for that element).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org