Re: DO NOT REPLY [Bug 37639] New: - [PATCH] Whitespace handling revised

[Andreas L Delmelle <a_...@pandora.be>]

On Nov 25, 2005, at 19:25, bugzilla@apache.org wrote:

Hi all,

I have some other questions/remarks that don't directly concern this,  
but I ran into them while looking at this so... Anyway, not really  
pressing matters, just wondering.

Concerning FObjMixed class hierarchy, which looks like
FObjMixed
   -> Block
   -> Marker
   -> RetrieveMarker
   -> BidiOverride
   -> Wrapper
   -> InlineLevel
        -> Leader
        -> Title
        -> Inline
             -> BasicLink

What is RetrieveMarker doing here? FObjMixed is a class meant for FOs  
that can also contain #PCDATA. Now, retrieve-marker should always be  
empty, so can't have *any* child nodes...
(Note: Perhaps we should consider writing a custom superclass for FOs  
that are empty by definition (?))

Why does BasicLink descend from Inline, and not InlineLevel?

Looking at this (and the posted patch), it may be interesting to note  
that my current whitespace handling strategy treats all FObjMixed the  
same way, with the notable exception of Block. All the others are  
treated the same as inlines: no whitespace-collapsing with preceding  
or following space, leading and trailing spaces are at most collapsed  
to one space. (The exception being when the character preceding a  
given node is a linefeed...)


Cheers,

Andreas