[jira] [Commented] (HDFS-17023) RBF: Record proxy time when call invokeConcurrent method.

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-17023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725065#comment-17725065 ] 

ASF GitHub Bot commented on HDFS-17023:
---------------------------------------

goiri commented on code in PR #5683:
URL: https://github.com/apache/hadoop/pull/5683#discussion_r1200874532


##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java:
##########
@@ -1572,7 +1572,9 @@ public <T extends RemoteLocationContext, R> Map<T, R> invokeConcurrent(
           results.add(new RemoteResult<>(location, ioe));
         }
       }
-
+      if (rpcMonitor != null) {
+        rpcMonitor.proxyOpComplete(true, null, null);

Review Comment:
   Some unit test?





> RBF: Record proxy time when call invokeConcurrent method.
> ---------------------------------------------------------
>
>                 Key: HDFS-17023
>                 URL: https://issues.apache.org/jira/browse/HDFS-17023
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: rbf
>    Affects Versions: 3.3.4
>            Reporter: farmmamba
>            Priority: Minor
>              Labels: pull-request-available
>
> Currently, we only invoke below code snippet in invokeConcurrent method.
> {code:java}
> if (rpcMonitor != null) {
>   rpcMonitor.proxyOp();
> } {code}
> Whether should we invoke `proxyOpComplete` method like what invokeMethod does or not?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org