[GitHub] [pulsar] eolivelli commented on a change in pull request #11115: fix flaky test testUpdateDynamicLocalConfiguration

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #11115:
URL: https://github.com/apache/pulsar/pull/11115#discussion_r659298275



##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiTest.java
##########
@@ -615,18 +615,18 @@ public void testInvalidDynamicConfigContentInZK() throws Exception {
      *
      * @throws Exception
      */
-    @Test
+    @Test(timeOut = 30000)
     public void testUpdateDynamicLocalConfiguration() throws Exception {
         // (1) try to update dynamic field
         final long initValue = 30000;
         final long shutdownTime = 10;
         pulsar.getConfiguration().setBrokerShutdownTimeoutMs(initValue);
         // update configuration
         admin.brokers().updateDynamicConfiguration("brokerShutdownTimeoutMs", Long.toString(shutdownTime));
-        Awaitility.await().until(()
-                -> pulsar.getConfiguration().getBrokerShutdownTimeoutMs() != initValue);
         // verify value is updated
-        assertEquals(pulsar.getConfiguration().getBrokerShutdownTimeoutMs(), shutdownTime);
+        Awaitility.waitAtMost(30, TimeUnit.SECONDS).untilAsserted(() -> {

Review comment:
       Do you have logs?
   
   30 seconds is very much.
   
   And also we are using some MockZookeeper here probably 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org