You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "spuru9 (via GitHub)" <gi...@apache.org> on 2026/09/09 15:00:54 UTC
Re: [PR] [FLINK-40478][runtime-web] Log effective HistoryServer configuration at startup [flink]
spuru9 commented on code in PR #29020:
URL: https://github.com/apache/flink/pull/29020#discussion_r3969907294
##########
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServer.java:
##########
@@ -261,6 +261,19 @@ public HistoryServer(
archiveLoadMode = config.get(HistoryServerOptions.HISTORY_SERVER_ARCHIVE_LOAD_MODE);
HistoryServerOptions.HistoryServerArchiveStorageType archiveStorageType =
config.get(HistoryServerOptions.HISTORY_SERVER_ARCHIVE_STORAGE_TYPE);
+ LOG.info(
+ "HistoryServer effective configuration: storage-type={}, load-mode={}, "
+ + "retained-jobs={}, retained-applications={}, retained-ttl={}, "
+ + "clean-expired-jobs={}, clean-expired-applications={}.",
Review Comment:
**nit:** the `retained-*` and `clean-expired-*` labels match their config keys exactly, but `storage-type` and `load-mode` don't — the real keys use dots (`historyserver.archive.storage.type` and `...load.mode`). Aligning them keeps this line grep-able against the config file. Not a blocker.
```suggestion
"HistoryServer effective configuration: storage.type={}, load.mode={}, "
+ "retained-jobs={}, retained-applications={}, retained-ttl={}, "
+ "clean-expired-jobs={}, clean-expired-applications={}.",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org