[GitHub] [incubator-superset] kristw commented on a change in pull request #9341: feat(visualization): add timeRangeFixed and value fallback to Big Number w/ Trendlines

[GitBox <gi...@apache.org>]

kristw commented on a change in pull request #9341: feat(visualization): add timeRangeFixed and value fallback to Big Number w/ Trendlines
URL: https://github.com/apache/incubator-superset/pull/9341#discussion_r401794083
 
 

 ##########
 File path: superset-frontend/src/explore/controls.jsx
 ##########
 @@ -857,6 +857,24 @@ export const controls = {
     }),
   },
 
+  time_range_fixed: {
+    type: 'CheckboxControl',
+    label: t('Fix to selected Time Range'),
+    description: t(
+      'Fix the trend line to the full time range specified in case filtered results do not include the start or end dates',
+    ),
+    renderTrigger: true,
+    visibility(props) {
+      const {
+        time_range: timeRange,
+        viz_type: vizType,
+        show_trend_line: showTrendLine,
+      } = props.form_data;
+      // if (vizType === 'big_number' && !showTrendLine) return false;
 
 Review comment:
   remove comment

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org