You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org> on 2018/04/10 00:52:23 UTC
[Impala-ASF-CR] IMPALA-5814: Remove startup flag to disable admission control
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9964
Change subject: IMPALA-5814: Remove startup flag to disable admission control
......................................................................
IMPALA-5814: Remove startup flag to disable admission control
Remove "--disable admission control" startup flag and its related
functionality and usage.
Change-Id: I9bf4087ce03ca63f82fd27c6d94b578881b85d42
---
M be/src/runtime/coordinator.cc
M be/src/runtime/exec-env.cc
M be/src/service/client-request-state.cc
M bin/generate_minidump_collection_testdata.py
M docs/topics/impala_admission.xml
M tests/custom_cluster/test_admission_controller.py
6 files changed, 12 insertions(+), 36 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/9964/1
--
To view, visit http://gerrit.cloudera.org:8080/9964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9bf4087ce03ca63f82fd27c6d94b578881b85d42
Gerrit-Change-Number: 9964
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
[Impala-ASF-CR] IMPALA-5814: Remove startup flag to disable admission control
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9964 )
Change subject: IMPALA-5814: Remove startup flag to disable admission control
......................................................................
Patch Set 2: -Code-Review
Actually we should separate out the doc component into a separate commit, since we don't run the docs build on code commits.
--
To view, visit http://gerrit.cloudera.org:8080/9964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9bf4087ce03ca63f82fd27c6d94b578881b85d42
Gerrit-Change-Number: 9964
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Apr 2018 20:46:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5814: Remove startup flag to disable admission control
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9964 )
Change subject: IMPALA-5814: Remove startup flag to disable admission control
......................................................................
IMPALA-5814: Remove startup flag to disable admission control
Remove "--disable admission control" startup flag and its related
functionality and usage.
Cherry-picks: not for 2.x
Change-Id: I9bf4087ce03ca63f82fd27c6d94b578881b85d42
Reviewed-on: http://gerrit.cloudera.org:8080/9964
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/common/global-flags.cc
M be/src/runtime/coordinator.cc
M be/src/runtime/exec-env.cc
M be/src/service/client-request-state.cc
M bin/generate_minidump_collection_testdata.py
M tests/custom_cluster/test_admission_controller.py
6 files changed, 13 insertions(+), 20 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9bf4087ce03ca63f82fd27c6d94b578881b85d42
Gerrit-Change-Number: 9964
Gerrit-PatchSet: 4
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-5814: Remove startup flag to disable admission control
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Hello Philip Zeyliger, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9964
to look at the new patch set (#2).
Change subject: IMPALA-5814: Remove startup flag to disable admission control
......................................................................
IMPALA-5814: Remove startup flag to disable admission control
Remove "--disable admission control" startup flag and its related
functionality and usage.
Cherry-picks: not for 2.x
Change-Id: I9bf4087ce03ca63f82fd27c6d94b578881b85d42
---
M be/src/common/global-flags.cc
M be/src/runtime/coordinator.cc
M be/src/runtime/exec-env.cc
M be/src/service/client-request-state.cc
M bin/generate_minidump_collection_testdata.py
M docs/topics/impala_admission.xml
M tests/custom_cluster/test_admission_controller.py
7 files changed, 13 insertions(+), 36 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/9964/2
--
To view, visit http://gerrit.cloudera.org:8080/9964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9bf4087ce03ca63f82fd27c6d94b578881b85d42
Gerrit-Change-Number: 9964
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-5814: Remove startup flag to disable admission control
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9964 )
Change subject: IMPALA-5814: Remove startup flag to disable admission control
......................................................................
Patch Set 2: Code-Review+1
All the changes looked pretty mechanical to me.
--
To view, visit http://gerrit.cloudera.org:8080/9964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9bf4087ce03ca63f82fd27c6d94b578881b85d42
Gerrit-Change-Number: 9964
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Apr 2018 23:39:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5814: Remove startup flag to disable admission control
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9964 )
Change subject: IMPALA-5814: Remove startup flag to disable admission control
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9bf4087ce03ca63f82fd27c6d94b578881b85d42
Gerrit-Change-Number: 9964
Gerrit-PatchSet: 3
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Apr 2018 21:05:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5814: Remove startup flag to disable admission control
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9964 )
Change subject: IMPALA-5814: Remove startup flag to disable admission control
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9bf4087ce03ca63f82fd27c6d94b578881b85d42
Gerrit-Change-Number: 9964
Gerrit-PatchSet: 3
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Apr 2018 21:34:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5814: Remove startup flag to disable admission control
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9964 )
Change subject: IMPALA-5814: Remove startup flag to disable admission control
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
This looks good. I don't think the change will be user-visible unless they have disabled admission control but provided admission control config files (since the default even with AC enabled is to not apply any limits).
http://gerrit.cloudera.org:8080/#/c/9964/2/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:
http://gerrit.cloudera.org:8080/#/c/9964/2/be/src/runtime/coordinator.cc@787
PS2, Line 787: DCHECK(admission_controller);
nit: != nullptr
--
To view, visit http://gerrit.cloudera.org:8080/9964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9bf4087ce03ca63f82fd27c6d94b578881b85d42
Gerrit-Change-Number: 9964
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Apr 2018 20:39:52 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5814: Remove startup flag to disable admission control
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9964 )
Change subject: IMPALA-5814: Remove startup flag to disable admission control
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2293/
--
To view, visit http://gerrit.cloudera.org:8080/9964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9bf4087ce03ca63f82fd27c6d94b578881b85d42
Gerrit-Change-Number: 9964
Gerrit-PatchSet: 3
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Apr 2018 17:11:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5814: Remove startup flag to disable admission control
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Hello Philip Zeyliger, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9964
to look at the new patch set (#3).
Change subject: IMPALA-5814: Remove startup flag to disable admission control
......................................................................
IMPALA-5814: Remove startup flag to disable admission control
Remove "--disable admission control" startup flag and its related
functionality and usage.
Cherry-picks: not for 2.x
Change-Id: I9bf4087ce03ca63f82fd27c6d94b578881b85d42
---
M be/src/common/global-flags.cc
M be/src/runtime/coordinator.cc
M be/src/runtime/exec-env.cc
M be/src/service/client-request-state.cc
M bin/generate_minidump_collection_testdata.py
M tests/custom_cluster/test_admission_controller.py
6 files changed, 13 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/9964/3
--
To view, visit http://gerrit.cloudera.org:8080/9964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9bf4087ce03ca63f82fd27c6d94b578881b85d42
Gerrit-Change-Number: 9964
Gerrit-PatchSet: 3
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-5814: Remove startup flag to disable admission control
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9964 )
Change subject: IMPALA-5814: Remove startup flag to disable admission control
......................................................................
Patch Set 2:
(1 comment)
> Actually we should separate out the doc component into a separate
> commit, since we don't run the docs build on code commits.
Done
http://gerrit.cloudera.org:8080/#/c/9964/2/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:
http://gerrit.cloudera.org:8080/#/c/9964/2/be/src/runtime/coordinator.cc@787
PS2, Line 787: DCHECK(admission_controller);
> nit: != nullptr
Done. Here and in client-request-state
--
To view, visit http://gerrit.cloudera.org:8080/9964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9bf4087ce03ca63f82fd27c6d94b578881b85d42
Gerrit-Change-Number: 9964
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Apr 2018 21:32:19 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5814: Remove startup flag to disable admission control
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9964 )
Change subject: IMPALA-5814: Remove startup flag to disable admission control
......................................................................
Patch Set 1:
> Could you add this flag to the graveyard? See commit
> 0047f813abc4dc8fb08a15ac8b9d0f582ab8a5f5 or look
> for this :)
>
> +// ++========================++
> +// || Startup flag graveyard ||
> +// ++========================++
> +//
> +// -----------
> +// -----------/ R I P ?
> +// / R I P ? -----------|-----------
> +// |-----------| |/ R I P ?
> +// | | LLAMA ||-----------|
> +// | Old Aggs | || |
> +// | | -- || Old Joins |
> +// | -- | || |
> +// | | || -- |
> +// | |~.~~.~~.~~~~| |
> +// ~~.~~.~~.~~~~ | |
> +// ~~.~~.~~.~~~~
Done
--
To view, visit http://gerrit.cloudera.org:8080/9964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9bf4087ce03ca63f82fd27c6d94b578881b85d42
Gerrit-Change-Number: 9964
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Apr 2018 23:13:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5814: Remove startup flag to disable admission control
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9964 )
Change subject: IMPALA-5814: Remove startup flag to disable admission control
......................................................................
Patch Set 1:
Could you add this flag to the graveyard? See commit 0047f813abc4dc8fb08a15ac8b9d0f582ab8a5f5 or look
for this :)
+// ++========================++
+// || Startup flag graveyard ||
+// ++========================++
+//
+// -----------
+// -----------/ R I P ╲
+// / R I P ╲ -----------|-----------
+// |-----------| |/ R I P ╲
+// | | LLAMA ||-----------|
+// | Old Aggs | || |
+// | | -- || Old Joins |
+// | -- | || |
+// | | || -- |
+// | |~.~~.~~.~~~~| |
+// ~~.~~.~~.~~~~ | |
+// ~~.~~.~~.~~~~
--
To view, visit http://gerrit.cloudera.org:8080/9964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9bf4087ce03ca63f82fd27c6d94b578881b85d42
Gerrit-Change-Number: 9964
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Apr 2018 00:56:38 +0000
Gerrit-HasComments: No