You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Alexander Thomas <al...@collab.net> on 2008/09/17 06:19:33 UTC
[PATCH] Issue 2489: Removing direct dependency to DBUS
Senthil Can you review the log message and other stuffs before I post it to the dev mailing list
[[[
Remove direct dependency to D-Bus library in GNOME Keyring.
* subversion/libsvn_auth_gnome_keyring/gnome_keyring.c
(gnome_keyring_password_get, gnome_keyring_password_set): Remove
dbus_bus_get() call.
* configure.ac:
Remove checking for dbus library, also remove D-Bus library and
header from the build.
Patch by: Alexander Thomas <al...@collab.net>
]]]
-Alexander Thomas(AT)
Re: [PATCH] Issue 2489: Removing direct dependency to DBUS
Posted by Senthil Kumaran S <se...@collab.net>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Senthil Kumaran S wrote:
> Alexander Thomas wrote:
>> [[[
>> Remove direct dependency to D-Bus library in GNOME Keyring.
>
>> * subversion/libsvn_auth_gnome_keyring/gnome_keyring.c
>> (gnome_keyring_password_get, gnome_keyring_password_set): Remove
>> dbus_bus_get() call.
>
>> * configure.ac:
>> Remove checking for dbus library, also remove D-Bus library and
>> header from the build.
>
>> Patch by: Alexander Thomas <al...@collab.net>
>> ]]]
>
> Committed in r33118.
Backported to 1.5.x-issue2489 branch via r33119.
- --
Senthil Kumaran S
http://www.stylesen.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
iD8DBQFI0NtB9o1G+2zNQDgRAv1nAJ4ta0lkV3JlnfG8/Aw2MSudM1f/WACglGc/
AaNR8uNW5XIsmbxDdlkxZ1U=
=bTMY
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Issue 2489: Removing direct dependency to DBUS
Posted by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>.
2008-09-18 13:11:26 Alexander Thomas napisał(a):
>
> On Wed, 2008-09-17 at 20:34 +0200, Arfrever Frehtes Taifersar Arahesis wrote:
> > 2008-09-17 09:29:10 Senthil Kumaran S napisał(a):
> > > Alexander Thomas wrote:
> > > > [[[
> > > > Remove direct dependency to D-Bus library in GNOME Keyring.
> > > >
> ...
> > > > ]]]
> > >
> > > Committed in r33118.
> >
> > This patch is wrong.
> > See r31269.
> >
> > The following warning is now shown when Subversion is run outside X session:
> > ** (process:NUMBER): WARNING **: couldn't connect to dbus session bus: dbus-launch failed to autolaunch D-Bus session: Autolaunch error: X11 initialization failed.
> >
>
> Its seems like r31269 was introduced to suppress this warning.?
Yes.
> Another important fact is that for just one function we introducing
> a new dependency.
It doesn't matter, because D-Bus is an unconditional dependency of GNOME
Keyring.
> AFAIK This warning can be suppressed by setting the
> DBUS_SESSION_BUS_ADDRESS env variable or by setting the
> GNOME_KEYRING_SOCKET evn variable.
We cannot expect that users will know these variables (especially what values
should be set).
This warning is shown even for users which don't have access to X session.
(I tested by using Subversion in tty1, while X session was owned by another
user.)
> By the way, when Subversion is ran outside X session and if the keyring
> is locked, what is really happening ?
After the aforementioned warning, Subversion asks if to store password in
plaintext form.
--
Arfrever Frehtes Taifersar Arahesis
Re: [PATCH] Issue 2489: Removing direct dependency to DBUS
Posted by Alexander Thomas <al...@collab.net>.
On Wed, 2008-09-17 at 20:34 +0200, Arfrever Frehtes Taifersar Arahesis wrote:
> 2008-09-17 09:29:10 Senthil Kumaran S napisał(a):
> > Alexander Thomas wrote:
> > > [[[
> > > Remove direct dependency to D-Bus library in GNOME Keyring.
> > >
...
> > > ]]]
> >
> > Committed in r33118.
>
> This patch is wrong.
> See r31269.
>
> The following warning is now shown when Subversion is run outside X session:
> ** (process:NUMBER): WARNING **: couldn't connect to dbus session bus: dbus-launch failed to autolaunch D-Bus session: Autolaunch error: X11 initialization failed.
>
Its seems like r31269 was introduced to suppress this warning.?
IMHO by calling dbus_bus_get() function we unnecessarily holding a dbus
connection and also its called multiple times one from SVN and from
gnome-keyring. Another important fact is that for just one function we
introducing a new dependency.
AFAIK This warning can be suppressed by setting the
DBUS_SESSION_BUS_ADDRESS env variable or by setting the
GNOME_KEYRING_SOCKET evn variable.
By the way, when Subversion is ran outside X session and if the keyring
is locked, what is really happening ?
-AT
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Issue 2489: Removing direct dependency to DBUS
Posted by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>.
2008-09-17 09:29:10 Senthil Kumaran S napisał(a):
> Alexander Thomas wrote:
> > [[[
> > Remove direct dependency to D-Bus library in GNOME Keyring.
> >
> > * subversion/libsvn_auth_gnome_keyring/gnome_keyring.c
> > (gnome_keyring_password_get, gnome_keyring_password_set): Remove
> > dbus_bus_get() call.
> >
> > * configure.ac:
> > Remove checking for dbus library, also remove D-Bus library and
> > header from the build.
> >
> > Patch by: Alexander Thomas <al...@collab.net>
> > ]]]
>
> Committed in r33118.
This patch is wrong.
See r31269.
The following warning is now shown when Subversion is run outside X session:
** (process:NUMBER): WARNING **: couldn't connect to dbus session bus: dbus-launch failed to autolaunch D-Bus session: Autolaunch error: X11 initialization failed.
--
Arfrever Frehtes Taifersar Arahesis
Re: [PATCH] Issue 2489: Removing direct dependency to DBUS
Posted by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>.
2008-09-17 09:29:10 Senthil Kumaran S napisał(a):
> Alexander Thomas wrote:
> > [[[
> > Remove direct dependency to D-Bus library in GNOME Keyring.
> >
> > * subversion/libsvn_auth_gnome_keyring/gnome_keyring.c
> > (gnome_keyring_password_get, gnome_keyring_password_set): Remove
> > dbus_bus_get() call.
> >
> > * configure.ac:
> > Remove checking for dbus library, also remove D-Bus library and
> > header from the build.
> >
> > Patch by: Alexander Thomas <al...@collab.net>
> > ]]]
>
> Committed in r33118.
r33118 was reverted in r33182.
--
Arfrever Frehtes Taifersar Arahesis
Re: [PATCH] Issue 2489: Removing direct dependency to DBUS
Posted by Senthil Kumaran S <se...@collab.net>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Alexander Thomas wrote:
> [[[
> Remove direct dependency to D-Bus library in GNOME Keyring.
>
> * subversion/libsvn_auth_gnome_keyring/gnome_keyring.c
> (gnome_keyring_password_get, gnome_keyring_password_set): Remove
> dbus_bus_get() call.
>
> * configure.ac:
> Remove checking for dbus library, also remove D-Bus library and
> header from the build.
>
> Patch by: Alexander Thomas <al...@collab.net>
> ]]]
Committed in r33118.
Thank You.
- --
Senthil Kumaran S
http://www.stylesen.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
iD8DBQFI0LHE9o1G+2zNQDgRAnZvAJ96zZgSbfjuQLRY9JByHGPSunn8NwCgkpVs
WlWegaM1uHRjjOuaFlqsit4=
=w7UD
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org