[GitHub] [unomi] jkevan commented on a diff in pull request #484: UNOMI-653 : add missing properties to pageInfo schema

[GitBox <gi...@apache.org>]

jkevan commented on code in PR #484:
URL: https://github.com/apache/unomi/pull/484#discussion_r958234808


##########
extensions/json-schema/services/src/main/resources/META-INF/cxs/schemas/items/page/page.properties.pageInfo.json:
##########
@@ -46,6 +46,14 @@
       "type": ["null", "string"],
       "format": "uri"
     },
+    "referrerQuery": {
+      "type": ["null", "string"],
+      "format": "string"

Review Comment:
   I dont think this format exists in json schema spec. Type "string" is enough anyway, there is no need for a specific format here.



##########
extensions/json-schema/services/src/main/resources/META-INF/cxs/schemas/items/page/page.properties.pageInfo.json:
##########
@@ -46,6 +46,14 @@
       "type": ["null", "string"],
       "format": "uri"
     },
+    "referrerQuery": {
+      "type": ["null", "string"],
+      "format": "string"
+    },
+    "referrerHost": {
+      "type": ["null", "string"],
+      "format": "string"

Review Comment:
   I dont think this format exists in json schema spec. Type "string" is enough anyway, there is no need for a specific format here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org