[jira] Commented: (CASSANDRA-8) Misspelled ColumSort attribute results in deleted commit logs and .db files

["Jeff Hammerbacher (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688070#action_12688070 ] 

Jeff Hammerbacher commented on CASSANDRA-8:
-------------------------------------------

>From Alexander Staubo:

"""
I was confused by the meaning of the "ColumnSort" attribute in the
config file, and typed something invalid. The result was the following
exception on compaction, when Cassandra starts up:

java.lang.NullPointerException
       at org.apache.cassandra.config.DatabaseDescriptor.getTypeInfo(DatabaseDescriptor.java:729)
       at org.apache.cassandra.db.ColumnIndexer.serialize(ColumnIndexer.java:62)
       at org.apache.cassandra.db.CompactSerializerInvocationHandler.invoke(CompactSerializerInvocationHandler.java:50)
       at $Proxy0.serialize(Unknown Source)
       at org.apache.cassandra.db.Memtable.flushForRandomPartitioner(Memtable.java:461)
       at org.apache.cassandra.db.Memtable.flush(Memtable.java:440)
       at org.apache.cassandra.db.Memtable.forceflush(Memtable.java:279)
       at org.apache.cassandra.db.ColumnFamilyStore.forceFlush(ColumnFamilyStore.java:409)
       at org.apache.cassandra.db.Table.flush(Table.java:857)
       at org.apache.cassandra.db.CommitLog.doRecovery(CommitLog.java:408)
       at org.apache.cassandra.db.CommitLog.recover(CommitLog.java:317)
       at org.apache.cassandra.db.RecoveryManager.recoverEachTable(RecoveryManager.java:90)
       at org.apache.cassandra.db.RecoveryManager.doRecovery(RecoveryManager.java:77)
       at org.apache.cassandra.db.DBManager.<init>(DBManager.java:112)
       at org.apache.cassandra.db.DBManager.instance(DBManager.java:61)
       at org.apache.cassandra.service.StorageService.start(StorageService.java:465)
       at org.apache.cassandra.service.CassandraServer.start(CassandraServer.java:96)
       at org.apache.cassandra.service.CassandraServer.main(CassandraServer.java:1049)

...after which the commit logs were gone, and there were no .db files.
So my database went *poof*.

The attached patch emits a warning if the ColumnSort attribute is
invalid, and uses the appropriate default of "Time" in that case.

However, this fixes only one possible failure scenario for
compactions, but not the underlying problem that a failing compaction
hoses the database. In my opinion, failing compactions should never
result in the commit logs being deleted, regardless of the failure
cause.
"""

> Misspelled ColumSort attribute results in deleted commit logs and .db files
> ---------------------------------------------------------------------------
>
>                 Key: CASSANDRA-8
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Jeff Hammerbacher
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.