[GitHub] beam pull request #2546: [BEAM-1972] Only compile HIFIO ITs when compiling w...

[ssisk <gi...@git.apache.org>]

GitHub user ssisk opened a pull request:

    https://github.com/apache/beam/pull/2546

    [BEAM-1972] Only compile HIFIO ITs when compiling with java 8.

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [X] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [X] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [X] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [X] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    The HIFIO jdk1.8-tests directory contains dependencies that require java8 (notably cassandra.) 
    
    The enforcer rules in jdk1.8-test mean that enforcer won't treat that as a problem, however the module itself was still compiling in that scenario.  This change makes it so that the module is skipped.
    
    I've verified this fix works by doing mvn clean verify on a machine with java8 and a machine with only java7 (which previously failed mvn clean verify) - I also verified that the jdk1.8-tests module actually compiled on the java8 machine and that we can still run the integration tests.
    
    mvn is a tricky one, so let me know if there's something I haven't thought of/etc...
    
    Presumably, we will need java8-only modules in the future, so I'm guessing this will be a pattern that may be followed elsewhere (eg. in the upcoming cassandra module - cc @jbonofre )
    
    R @dhalperi 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ssisk/beam enforcer-j7

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2546.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2546
    
----
commit 06c8cf865e4030312b4563e690156c8b44636191
Author: Stephen Sisk <si...@google.com>
Date:   2017-04-15T00:27:22Z

    Only compile HIFIO ITs when compiling with java 8.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] beam pull request #2546: [BEAM-1972] Only compile HIFIO ITs when compiling w...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/2546


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---