[GitHub] [iotdb] qiaojialin commented on a diff in pull request #5763: [IOTDB-3034] Partial insert in new cluster

[GitBox <gi...@apache.org>]

qiaojialin commented on code in PR #5763:
URL: https://github.com/apache/iotdb/pull/5763#discussion_r862605187


##########
server/src/main/java/org/apache/iotdb/db/mpp/sql/planner/plan/node/write/InsertRowNode.java:
##########
@@ -172,17 +173,16 @@ public boolean validateSchema(SchemaTree schemaTree) {
         return false;
       }
     } else {
-      // todo partial insert
       if (deviceSchemaInfo.isAligned() != isAligned) {
         return false;
       }
 
       for (int i = 0; i < measurementSchemas.size(); i++) {
         if (dataTypes[i] != measurementSchemas.get(i).getType()) {
-          if (IoTDBDescriptor.getInstance().getConfig().isEnablePartialInsert()) {
+          if (!IoTDBDescriptor.getInstance().getConfig().isEnablePartialInsert()) {

Review Comment:
   add a test case



##########
server/src/main/java/org/apache/iotdb/db/mpp/sql/planner/plan/node/write/InsertRowNode.java:
##########
@@ -223,7 +209,7 @@ public void transferType(List<MeasurementSchema> measurementSchemas)
       for (int i = 0; i < measurementSchemas.size(); i++) {
         if (measurementSchemas.get(i) == null) {

Review Comment:
    what is equal to null mean?  add javadoc



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org