You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2017/07/06 22:46:16 UTC
[kudu-CR] consensus: Get rid of RaftConsensus::Create()
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7192
to look at the new patch set (#6).
Change subject: consensus: Get rid of RaftConsensus::Create()
......................................................................
consensus: Get rid of RaftConsensus::Create()
It is no longer useful to have a factory method for RaftConsensus,
particularly since we need to be able to separate creation from
initialization in a follow-up patch. This is a minor refactor that
removes Create() and simplifies a couple of things.
Also adds an additional lifecycle state to RaftConsensus (kNew) for
validation purposes.
Also remove unused MemTracker instance from RaftConsensus.
Change-Id: Ic28fb8fe64cd62d290cea1de22c4ba9dd1743a4e
---
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/tablet/tablet_replica.cc
4 files changed, 202 insertions(+), 250 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/7192/6
--
To view, visit http://gerrit.cloudera.org:8080/7192
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic28fb8fe64cd62d290cea1de22c4ba9dd1743a4e
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot