You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/02/28 19:25:10 UTC
[GitHub] [accumulo] milleruntime opened a new pull request #1538: Fix
DatafileManager MajC for empty files. Closes #1535
milleruntime opened a new pull request #1538: Fix DatafileManager MajC for empty files. Closes #1535
URL: https://github.com/apache/accumulo/pull/1538
* Don't rename the file if it is empty
* Don't add the file to the list of files if it is empty
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [accumulo] milleruntime merged pull request #1538: Fix
DatafileManager MajC for empty files. Closes #1535
Posted by GitBox <gi...@apache.org>.
milleruntime merged pull request #1538: Fix DatafileManager MajC for empty files. Closes #1535
URL: https://github.com/apache/accumulo/pull/1538
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [accumulo] milleruntime commented on issue #1538: Fix
DatafileManager MajC for empty files. Closes #1535
Posted by GitBox <gi...@apache.org>.
milleruntime commented on issue #1538: Fix DatafileManager MajC for empty files. Closes #1535
URL: https://github.com/apache/accumulo/pull/1538#issuecomment-593498309
Thanks @keith-turner
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [accumulo] keith-turner commented on a change in pull request
#1538: Fix DatafileManager MajC for empty files. Closes #1535
Posted by GitBox <gi...@apache.org>.
keith-turner commented on a change in pull request #1538: Fix DatafileManager MajC for empty files. Closes #1535
URL: https://github.com/apache/accumulo/pull/1538#discussion_r385934028
##########
File path: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileManager.java
##########
@@ -500,12 +500,13 @@ StoredTabletFile bringMajorCompactionOnline(Set<StoredTabletFile> oldDatafiles,
throw new IllegalStateException("Target map file already exist " + newDatafile);
}
- // rename before putting in metadata table, so files in metadata table should
- // always exist
- rename(tablet.getTabletServer().getFileSystem(), tmpDatafile.getPath(), newDatafile.getPath());
-
if (dfv.getNumEntries() == 0) {
tablet.getTabletServer().getFileSystem().deleteRecursively(newDatafile.getPath());
Review comment:
```suggestion
tablet.getTabletServer().getFileSystem().deleteRecursively(tmpDatafile.getPath());
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services