[jira] [Commented] (BIGTOP-2209) Add hive dml tests using hive cli

["YoungWoo Kim (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BIGTOP-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15142709#comment-15142709 ] 

YoungWoo Kim commented on BIGTOP-2209:
--------------------------------------

[~kollavenkat], Overly looks good! minor nit:
{code}
+  private static String date = sh.exec("/bin/date").getOut().get(0).replaceAll("\\s","").replaceAll(":","");
+  private static tmpScriptsFolder = "/tmp/TestHiveDMLWithHiveCLI_${date}";
{code}
/bin/date returns non-alphabet characters because it's affected by the environment variable 'LANG'. Like following:
{code}
$ date
2016년 2월 11일 목요일 22시 15분 00초 KST
$ echo $LANG
ko_KR.UTF-8
{code}
IMO, Would be good and safe to specify a format for the 'String date' to remove inappropriate characters. e.x., "/bin/date +%Y%m%d" 

What do you think?

> Add hive dml tests using hive cli
> ---------------------------------
>
>                 Key: BIGTOP-2209
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-2209
>             Project: Bigtop
>          Issue Type: Sub-task
>          Components: general
>            Reporter: Venkata Srinivasa Rao Kolla 
>            Assignee: Venkata Srinivasa Rao Kolla 
>         Attachments: BIGTOP-2209-hivedmlwithhivecli.patch
>
>
> Add tests which uses hivecli to run hive dml scripts.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)