You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/20 08:06:31 UTC

[GitHub] [pulsar] AlvaroStream opened a new pull request, #17734: [improve][doc] Add options to stats and partitioned-stats

AlvaroStream opened a new pull request, #17734:
URL: https://github.com/apache/pulsar/pull/17734

   ### Motivation
   
   I noticed there were some options not shown in the documentation but offered in the help of the tool.
   
   ### Modifications
   
   Add the options to stats and partitioned-stats in topics.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If the box was checked, please highlight the changes*
   
   - [ ] Dependencies (add or upgrade a dependency)
   - [ ] The public API
   - [ ] The schema
   - [ ] The default values of configurations
   - [ ] The binary protocol
   - [ ] The REST endpoints
   - [ ] The admin CLI options
   - [ ] Anything that affects deployment
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
   
   - [ ] `doc-not-needed` 
   (Please explain why)
   
   - [ X] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)
   
   ### Matching PR in forked repository
   
   PR in forked repository: <!-- ENTER URL HERE 
   
   After opening this PR, the build in apache/pulsar will fail and instructions will
   be provided for opening a PR in the PR author's forked repository.
   
   apache/pulsar pull requests should be first tested in your own fork since the 
   apache/pulsar CI based on GitHub Actions has constrained resources and quota.
   GitHub Actions provides separate quota for pull requests that are executed in 
   a forked repository.
   
   The tests will be run in the forked repository until all PR review comments have
   been handled, the tests pass and the PR is approved by a reviewer.
   
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Technoboy- merged pull request #17734: [improve][doc] Add options to stats and partitioned-stats

Posted by GitBox <gi...@apache.org>.
Technoboy- merged PR #17734:
URL: https://github.com/apache/pulsar/pull/17734


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on a diff in pull request #17734: [improve][doc] Add options to stats and partitioned-stats

Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #17734:
URL: https://github.com/apache/pulsar/pull/17734#discussion_r975346201


##########
site2/docs/reference-pulsar-admin.md:
##########
@@ -2429,6 +2429,15 @@ Usage
 pulsar-admin topics stats topic
 ```
 
+Options
+
+|Flag|Description|Default|
+|---|---|---|
+|`-etb`,`--get-earliest-time-in-backlog` | Set true to get earliest time in backlog | false |

Review Comment:
   ```suggestion
   |`-etb`,`--get-earliest-time-in-backlog` | Set to `true` to get the earliest time in backlog | false |
   ```



##########
site2/docs/reference-pulsar-admin.md:
##########
@@ -2429,6 +2429,15 @@ Usage
 pulsar-admin topics stats topic
 ```
 
+Options
+
+|Flag|Description|Default|
+|---|---|---|
+|`-etb`,`--get-earliest-time-in-backlog` | Set true to get earliest time in backlog | false |
+|`-gpb`,`--get-precise-backlog`| Set true to get precise backlog | false |

Review Comment:
   ```suggestion
   |`-gpb`,`--get-precise-backlog`| Set to `true` to get precise backlog | false |
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on a diff in pull request #17734: [improve][doc] Add options to stats and partitioned-stats

Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #17734:
URL: https://github.com/apache/pulsar/pull/17734#discussion_r975346434


##########
site2/docs/reference-pulsar-admin.md:
##########
@@ -2429,6 +2429,15 @@ Usage
 pulsar-admin topics stats topic
 ```
 
+Options
+
+|Flag|Description|Default|
+|---|---|---|
+|`-etb`,`--get-earliest-time-in-backlog` | Set true to get earliest time in backlog | false |
+|`-gpb`,`--get-precise-backlog`| Set true to get precise backlog | false |
+|`-sbs`,` --get-subscription-backlog-size`| Set true to get backlog size for each subscription, locking required | false | 

Review Comment:
   ```suggestion
   |`-sbs`,` --get-subscription-backlog-size`| Set to `true` to get backlog size for each subscription, locking required | false | 
   ```



##########
site2/docs/reference-pulsar-admin.md:
##########
@@ -2466,8 +2475,11 @@ Options
 
 |Flag|Description|Default|
 |---|---|---|
+|`-gpb`,`--get-precise-backlog`| Set true to get precise backlog | false |

Review Comment:
   ```suggestion
   |`-gpb`,`--get-precise-backlog`| Set to `true` to get precise backlog | false |
   ```



##########
site2/docs/reference-pulsar-admin.md:
##########
@@ -2466,8 +2475,11 @@ Options
 
 |Flag|Description|Default|
 |---|---|---|
+|`-gpb`,`--get-precise-backlog`| Set true to get precise backlog | false |
+|`-sbs`,` --get-subscription-backlog-size`| Set true to get backlog size for each subscription, locking required | false | 

Review Comment:
   ```suggestion
   |`-sbs`,` --get-subscription-backlog-size`| Set to `true` to get backlog size for each subscription, locking required | false | 
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org