You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Paul Lindner (JIRA)" <ji...@apache.org> on 2010/01/13 23:33:54 UTC

[jira] Resolved: (SHINDIG-1264) Cleanup javascript for use with closure-compiler

     [ https://issues.apache.org/jira/browse/SHINDIG-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Lindner resolved SHINDIG-1264.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.1-BETA6

js fixes checked in


> Cleanup javascript for use with closure-compiler
> ------------------------------------------------
>
>                 Key: SHINDIG-1264
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1264
>             Project: Shindig
>          Issue Type: Bug
>          Components: Javascript 
>    Affects Versions: 1.1-BETA5
>            Reporter: Paul Lindner
>             Fix For: 1.1-BETA6
>
>
> The closure compiler is very picky about jsdoc comments.  It found a number of issues.
> codereview here:
> http://codereview.appspot.com/186110
> Changes needed include lowercasing built-in types ({String Boolean, etc} to string, boolean
> Remove Map.<> syntax and use Object.<> syntax
> remove entities (&lt; etc...)
> give functions proper arguments.
> etc

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.