You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/06/05 21:39:26 UTC

[GitHub] [incubator-mxnet] wkcn commented on a change in pull request #18492: [Bug Fixed] fix batch norm when `fix_gamma` is True

wkcn commented on a change in pull request #18492:
URL: https://github.com/apache/incubator-mxnet/pull/18492#discussion_r436175871



##########
File path: src/operator/nn/cudnn/cudnn_batch_norm-inl.h
##########
@@ -228,7 +228,7 @@ class CuDNNBatchNormOp {
         &a,
         &b,
         &a,
-        req[cudnnbatchnorm::kGamma] == kWriteTo ? &b: &b_add,
+        req[cudnnbatchnorm::kGamma] == kAddTo ? &b_add : &b,

Review comment:
       @sxjscience @zhreshold Thanks for your review! I will add the grad_req check and an unittest for gradient accumulation.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org