You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by ro...@apache.org on 2020/06/08 13:16:17 UTC
[james-project] 23/30: JAMES-3179 Fix MaildirMessage leak
This is an automated email from the ASF dual-hosted git repository.
rouazana pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git
commit 9f15eb226abffa8db30a993410beb4a7c4b15b71
Author: Gautier DI FOLCO <gd...@linagora.com>
AuthorDate: Tue May 12 17:51:36 2020 +0200
JAMES-3179 Fix MaildirMessage leak
---
.../org/apache/james/mailbox/maildir/mail/model/MaildirMessage.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/mail/model/MaildirMessage.java b/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/mail/model/MaildirMessage.java
index 0195b58..d094699 100644
--- a/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/mail/model/MaildirMessage.java
+++ b/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/mail/model/MaildirMessage.java
@@ -275,9 +275,9 @@ public class MaildirMessage implements Message {
@Override
public List<MessageAttachmentMetadata> getAttachments() {
- try {
+ try (InputStream fullContent = getFullContent()) {
AtomicInteger counter = new AtomicInteger(0);
- return new MessageParser().retrieveAttachments(getFullContent())
+ return new MessageParser().retrieveAttachments(fullContent)
.stream()
.map(Throwing.<ParsedAttachment, MessageAttachmentMetadata>function(
attachmentMetadata -> attachmentMetadata.asMessageAttachment(generateFixedAttachmentId(counter.incrementAndGet())))
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org